Skip to content

Commit b902bc2

Browse files
authoredDec 19, 2023
[BugFix] Remove annotations from search service (#370)
Signed-off-by: yandongxiao <[email protected]>
1 parent 972668c commit b902bc2

File tree

1 file changed

+5
-1
lines changed
  • pkg/k8sutils/templates/service

1 file changed

+5
-1
lines changed
 

‎pkg/k8sutils/templates/service/spec.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,17 @@
1515
package service
1616

1717
import (
18-
"github.com/StarRocks/starrocks-kubernetes-operator/pkg/apis/starrocks/v1"
1918
corev1 "k8s.io/api/core/v1"
19+
20+
"github.com/StarRocks/starrocks-kubernetes-operator/pkg/apis/starrocks/v1"
2021
)
2122

2223
func MakeSearchService(serviceName string, externalService *corev1.Service, ports []corev1.ServicePort) *corev1.Service {
2324
searchSvc := &corev1.Service{}
2425
externalService.ObjectMeta.DeepCopyInto(&searchSvc.ObjectMeta)
26+
// some service annotations can only be used when `type` is 'LoadBalancer', e.g. service.beta.kubernetes.io/load-balancer-source-ranges
27+
// we do not need to annotations for search service
28+
searchSvc.Annotations = nil
2529
searchSvc.Name = serviceName
2630
searchSvc.Spec = corev1.ServiceSpec{
2731
ClusterIP: "None",

0 commit comments

Comments
 (0)
Please sign in to comment.