Skip to content

Prefer to use containerPort to export service node port #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yandongxiao opened this issue Dec 20, 2023 · 0 comments · Fixed by #421
Closed

Prefer to use containerPort to export service node port #378

yandongxiao opened this issue Dec 20, 2023 · 0 comments · Fixed by #421
Labels
enhancement New feature or request

Comments

@yandongxiao
Copy link
Collaborator

Describe the current behavior

When user want to export service node port, It should write following conf:

  service:
    type: NodePort
    ports:
      - name: http-port   # fill the name from the fe proxy service ports
        containerPort: 8080
        nodePort: 30180
        port: 8080

name is required field, and must keep the same with the name defined in k8s service.

But If users Start from scratch, they do not know the port.name.

Describe the enhancement

If user specify containerPort and name, first use containerPort to match, then use name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant