Skip to content

Commit 0b948eb

Browse files
code optimization
1 parent 241557d commit 0b948eb

36 files changed

+69
-80
lines changed

actuator/src/main/java/org/tron/core/actuator/AccountPermissionUpdateActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ public AccountPermissionUpdateActuator() {
3333

3434
@Override
3535
public boolean execute(Object object) throws ContractExeException {
36-
TransactionResultCapsule result = (TransactionResultCapsule)object;
37-
if (Objects.isNull(result)){
36+
TransactionResultCapsule result = (TransactionResultCapsule) object;
37+
if (Objects.isNull(result)) {
3838
throw new RuntimeException("TransactionResultCapsule is null");
3939
}
4040

actuator/src/main/java/org/tron/core/actuator/AssetIssueActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ public AssetIssueActuator() {
4949

5050
@Override
5151
public boolean execute(Object result) throws ContractExeException {
52-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
53-
if (Objects.isNull(ret)){
52+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
53+
if (Objects.isNull(ret)) {
5454
throw new RuntimeException("TransactionResultCapsule is null");
5555
}
5656

actuator/src/main/java/org/tron/core/actuator/ClearABIContractActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ public ClearABIContractActuator() {
2828

2929
@Override
3030
public boolean execute(Object result) throws ContractExeException {
31-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
32-
if (Objects.isNull(ret)){
31+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
32+
if (Objects.isNull(ret)) {
3333
throw new RuntimeException("TransactionResultCapsule is null");
3434
}
3535

actuator/src/main/java/org/tron/core/actuator/CreateAccountActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ public CreateAccountActuator() {
2727
@Override
2828
public boolean execute(Object result)
2929
throws ContractExeException {
30-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
31-
if (Objects.isNull(ret)){
30+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
31+
if (Objects.isNull(ret)) {
3232
throw new RuntimeException("TransactionResultCapsule is null");
3333
}
3434

actuator/src/main/java/org/tron/core/actuator/ExchangeCreateActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ public ExchangeCreateActuator() {
3232

3333
@Override
3434
public boolean execute(Object object) throws ContractExeException {
35-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
36-
if (Objects.isNull(ret)){
35+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
36+
if (Objects.isNull(ret)) {
3737
throw new RuntimeException("TransactionResultCapsule is null");
3838
}
3939

actuator/src/main/java/org/tron/core/actuator/ExchangeInjectActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ public ExchangeInjectActuator() {
3434

3535
@Override
3636
public boolean execute(Object object) throws ContractExeException {
37-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
38-
if (Objects.isNull(ret)){
37+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
38+
if (Objects.isNull(ret)) {
3939
throw new RuntimeException("TransactionResultCapsule is null");
4040
}
4141

actuator/src/main/java/org/tron/core/actuator/ExchangeTransactionActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ public ExchangeTransactionActuator() {
3333

3434
@Override
3535
public boolean execute(Object object) throws ContractExeException {
36-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
37-
if (Objects.isNull(ret)){
36+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
37+
if (Objects.isNull(ret)) {
3838
throw new RuntimeException("TransactionResultCapsule is null");
3939
}
4040

actuator/src/main/java/org/tron/core/actuator/ExchangeWithdrawActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ public ExchangeWithdrawActuator() {
3535

3636
@Override
3737
public boolean execute(Object object) throws ContractExeException {
38-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
39-
if (Objects.isNull(ret)){
38+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
39+
if (Objects.isNull(ret)) {
4040
throw new RuntimeException("TransactionResultCapsule is null");
4141
}
4242

actuator/src/main/java/org/tron/core/actuator/FreezeBalanceActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ public FreezeBalanceActuator() {
3434

3535
@Override
3636
public boolean execute(Object result) throws ContractExeException {
37-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
38-
if (Objects.isNull(ret)){
37+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
38+
if (Objects.isNull(ret)) {
3939
throw new RuntimeException("TransactionResultCapsule is null");
4040
}
4141

actuator/src/main/java/org/tron/core/actuator/ParticipateAssetIssueActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ public ParticipateAssetIssueActuator() {
4545

4646
@Override
4747
public boolean execute(Object object) throws ContractExeException {
48-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
49-
if (Objects.isNull(ret)){
48+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
49+
if (Objects.isNull(ret)) {
5050
throw new RuntimeException("TransactionResultCapsule is null");
5151
}
5252

actuator/src/main/java/org/tron/core/actuator/ProposalApproveActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ public ProposalApproveActuator() {
3535

3636
@Override
3737
public boolean execute(Object result) throws ContractExeException {
38-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
39-
if (Objects.isNull(ret)){
38+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
39+
if (Objects.isNull(ret)) {
4040
throw new RuntimeException("TransactionResultCapsule is null");
4141
}
4242

actuator/src/main/java/org/tron/core/actuator/ProposalCreateActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ public ProposalCreateActuator() {
3030

3131
@Override
3232
public boolean execute(Object result) throws ContractExeException {
33-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
34-
if (Objects.isNull(ret)){
33+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
34+
if (Objects.isNull(ret)) {
3535
throw new RuntimeException("TransactionResultCapsule is null");
3636
}
3737

actuator/src/main/java/org/tron/core/actuator/ProposalDeleteActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ public ProposalDeleteActuator() {
3333

3434
@Override
3535
public boolean execute(Object result) throws ContractExeException {
36-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
37-
if (Objects.isNull(ret)){
36+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
37+
if (Objects.isNull(ret)) {
3838
throw new RuntimeException("TransactionResultCapsule is null");
3939
}
4040

actuator/src/main/java/org/tron/core/actuator/SetAccountIdActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ public SetAccountIdActuator() {
2525

2626
@Override
2727
public boolean execute(Object result) throws ContractExeException {
28-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
29-
if (Objects.isNull(ret)){
28+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
29+
if (Objects.isNull(ret)) {
3030
throw new RuntimeException("TransactionResultCapsule is null");
3131
}
3232

actuator/src/main/java/org/tron/core/actuator/ShieldedTransferActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ public ShieldedTransferActuator() {
5656
@Override
5757
public boolean execute(Object result)
5858
throws ContractExeException {
59-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
60-
if (Objects.isNull(ret)){
59+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
60+
if (Objects.isNull(ret)) {
6161
throw new RuntimeException("TransactionResultCapsule is null");
6262
}
6363

actuator/src/main/java/org/tron/core/actuator/TransferActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ public TransferActuator() {
2929

3030
@Override
3131
public boolean execute(Object object) throws ContractExeException {
32-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
33-
if (Objects.isNull(ret)){
32+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
33+
if (Objects.isNull(ret)) {
3434
throw new RuntimeException("TransactionResultCapsule is null");
3535
}
3636

actuator/src/main/java/org/tron/core/actuator/TransferAssetActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ public TransferAssetActuator() {
4646

4747
@Override
4848
public boolean execute(Object result) throws ContractExeException {
49-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
50-
if (Objects.isNull(ret)){
49+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
50+
if (Objects.isNull(ret)) {
5151
throw new RuntimeException("TransactionResultCapsule is null");
5252
}
5353

actuator/src/main/java/org/tron/core/actuator/UnfreezeAssetActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ public UnfreezeAssetActuator() {
3030

3131
@Override
3232
public boolean execute(Object object) throws ContractExeException {
33-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
34-
if (Objects.isNull(ret)){
33+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
34+
if (Objects.isNull(ret)) {
3535
throw new RuntimeException("TransactionResultCapsule is null");
3636
}
3737

actuator/src/main/java/org/tron/core/actuator/UnfreezeBalanceActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ public UnfreezeBalanceActuator() {
4141

4242
@Override
4343
public boolean execute(Object result) throws ContractExeException {
44-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
45-
if (Objects.isNull(ret)){
44+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
45+
if (Objects.isNull(ret)) {
4646
throw new RuntimeException("TransactionResultCapsule is null");
4747
}
4848

actuator/src/main/java/org/tron/core/actuator/UpdateAccountActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ public UpdateAccountActuator() {
2424
@Override
2525
public boolean execute(Object result) throws ContractExeException {
2626

27-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
28-
if (Objects.isNull(ret)){
27+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
28+
if (Objects.isNull(ret)) {
2929
throw new RuntimeException("TransactionResultCapsule is null");
3030
}
3131

actuator/src/main/java/org/tron/core/actuator/UpdateAssetActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ public UpdateAssetActuator() {
2929

3030
@Override
3131
public boolean execute(Object object) throws ContractExeException {
32-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
33-
if (Objects.isNull(ret)){
32+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
33+
if (Objects.isNull(ret)) {
3434
throw new RuntimeException("TransactionResultCapsule is null");
3535
}
3636

actuator/src/main/java/org/tron/core/actuator/UpdateBrokerageActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ public UpdateBrokerageActuator() {
2828

2929
@Override
3030
public boolean execute(Object result) throws ContractExeException {
31-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
32-
if (Objects.isNull(ret)){
31+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
32+
if (Objects.isNull(ret)) {
3333
throw new RuntimeException("TransactionResultCapsule is null");
3434
}
3535

actuator/src/main/java/org/tron/core/actuator/UpdateEnergyLimitContractActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ public UpdateEnergyLimitContractActuator() {
2828

2929
@Override
3030
public boolean execute(Object object) throws ContractExeException {
31-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
32-
if (Objects.isNull(ret)){
31+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
32+
if (Objects.isNull(ret)) {
3333
throw new RuntimeException("TransactionResultCapsule is null");
3434
}
3535

actuator/src/main/java/org/tron/core/actuator/UpdateSettingContractActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ public UpdateSettingContractActuator() {
2727

2828
@Override
2929
public boolean execute(Object object) throws ContractExeException {
30-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
31-
if (Objects.isNull(ret)){
30+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
31+
if (Objects.isNull(ret)) {
3232
throw new RuntimeException("TransactionResultCapsule is null");
3333
}
3434

actuator/src/main/java/org/tron/core/actuator/VMActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ private static long getEnergyFee(long callerEnergyUsage, long callerEnergyFrozen
105105
public void validate(Object object) throws ContractValidateException {
106106

107107
TransactionContext context = (TransactionContext) object;
108-
if (Objects.isNull(context)){
108+
if (Objects.isNull(context)) {
109109
throw new RuntimeException("TransactionContext is null");
110110
}
111111

@@ -148,7 +148,7 @@ public void validate(Object object) throws ContractValidateException {
148148
@Override
149149
public void execute(Object object) throws ContractExeException {
150150
TransactionContext context = (TransactionContext) object;
151-
if (Objects.isNull(context)){
151+
if (Objects.isNull(context)) {
152152
throw new RuntimeException("TransactionContext is null");
153153
}
154154

actuator/src/main/java/org/tron/core/actuator/VoteWitnessActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ public VoteWitnessActuator() {
3838

3939
@Override
4040
public boolean execute(Object object) throws ContractExeException {
41-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
42-
if (Objects.isNull(ret)){
41+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
42+
if (Objects.isNull(ret)) {
4343
throw new RuntimeException("TransactionResultCapsule is null");
4444
}
4545

actuator/src/main/java/org/tron/core/actuator/WithdrawBalanceActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ public WithdrawBalanceActuator() {
3131

3232
@Override
3333
public boolean execute(Object result) throws ContractExeException {
34-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
35-
if (Objects.isNull(ret)){
34+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
35+
if (Objects.isNull(ret)) {
3636
throw new RuntimeException("TransactionResultCapsule is null");
3737
}
3838

actuator/src/main/java/org/tron/core/actuator/WitnessCreateActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ public WitnessCreateActuator() {
2929

3030
@Override
3131
public boolean execute(Object object) throws ContractExeException {
32-
TransactionResultCapsule ret = (TransactionResultCapsule)object;
33-
if (Objects.isNull(ret)){
32+
TransactionResultCapsule ret = (TransactionResultCapsule) object;
33+
if (Objects.isNull(ret)) {
3434
throw new RuntimeException("TransactionResultCapsule is null");
3535
}
3636

actuator/src/main/java/org/tron/core/actuator/WitnessUpdateActuator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ private void updateWitness(final WitnessUpdateContract contract) {
3333

3434
@Override
3535
public boolean execute(Object result) throws ContractExeException {
36-
TransactionResultCapsule ret = (TransactionResultCapsule)result;
37-
if (Objects.isNull(ret)){
36+
TransactionResultCapsule ret = (TransactionResultCapsule) result;
37+
if (Objects.isNull(ret)) {
3838
throw new RuntimeException("TransactionResultCapsule is null");
3939
}
4040

actuator/src/main/java/org/tron/core/vm/program/Program.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,10 @@ public int getPC() {
391391
return pc;
392392
}
393393

394+
public void setPC(DataWord pc) {
395+
this.setPC(pc.intValue());
396+
}
397+
394398
public void setPC(int pc) {
395399
this.pc = pc;
396400

@@ -399,10 +403,6 @@ public void setPC(int pc) {
399403
}
400404
}
401405

402-
public void setPC(DataWord pc) {
403-
this.setPC(pc.intValue());
404-
}
405-
406406
public boolean isStopped() {
407407
return stopped;
408408
}

chainbase/src/main/java/org/tron/common/storage/leveldb/LevelDbDataSourceImpl.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,7 @@ public Stream<Entry<byte[], byte[]>> parallelStream() {
457457

458458
@Override
459459
public LevelDbDataSourceImpl newInstance() {
460-
return new LevelDbDataSourceImpl(DBConfig.getOutputDirectoryByDbName(dataBaseName), dataBaseName, options, writeOptions);
460+
return new LevelDbDataSourceImpl(DBConfig.getOutputDirectoryByDbName(dataBaseName),
461+
dataBaseName, options, writeOptions);
461462
}
462463
}

chainbase/src/main/java/org/tron/common/utils/DBConfig.java

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.io.File;
44
import java.util.Map;
55
import java.util.Set;
6-
76
import lombok.Getter;
87
import lombok.Setter;
98
import org.apache.commons.lang3.StringUtils;

chainbase/src/main/java/org/tron/core/actuator/TransactionFactory.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import java.util.Map;
55
import java.util.Set;
66
import java.util.concurrent.ConcurrentHashMap;
7-
87
import org.tron.common.utils.DBConfig;
98
import org.tron.protos.Protocol.Transaction.Contract.ContractType;
109
import org.tron.protos.contract.SmartContractOuterClass.CreateSmartContract;
@@ -23,7 +22,8 @@ public class TransactionFactory {
2322
public static void register(ContractType type, Class<? extends Actuator> actuatorClass,
2423
Class<? extends GeneratedMessageV3> clazz) {
2524
Set<String> actuatorSet = DBConfig.getActuatorSet();
26-
if (actuatorClass != null && !actuatorSet.isEmpty() && !actuatorSet.contains(actuatorClass.getSimpleName())) {
25+
if (actuatorClass != null && !actuatorSet.isEmpty() && !actuatorSet
26+
.contains(actuatorClass.getSimpleName())) {
2727
return;
2828
}
2929

chainbase/src/main/java/org/tron/core/db2/core/SnapshotManager.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,8 @@ private void createCheckpoint() {
318318
}
319319

320320
checkTmpStore.getDbSource().updateByBatch(batch.entrySet().stream()
321-
.map(e -> Maps.immutableEntry(e.getKey().getBytes(), e.getValue().getBytes()))
322-
.collect(HashMap::new, (m, k) -> m.put(k.getKey(), k.getValue()), HashMap::putAll),
321+
.map(e -> Maps.immutableEntry(e.getKey().getBytes(), e.getValue().getBytes()))
322+
.collect(HashMap::new, (m, k) -> m.put(k.getKey(), k.getValue()), HashMap::putAll),
323323
WriteOptionsWrapper.getInstance().sync(DBConfig.isDbSync()));
324324
}
325325

0 commit comments

Comments
 (0)