Skip to content

chore(webserver): upgrade axum to 0.8, utoipa to 5.3 for apidoc merge… #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Apr 21, 2025

… feature

When working the API doc generation for ingestion API, we need the merge feature from utoipa, to merge the ee api routes into ApiDoc.

the merge was introduced since utoipa 0.5.

Everything is working fine after upgrade, Test:
CleanShot 2025-04-21 at 16 18 54@2x

CleanShot 2025-04-21 at 16 19 27@2x

CleanShot 2025-04-21 at 16 19 44@2x

@wsxiaoys
Copy link
Member

LGTM

@wsxiaoys wsxiaoys enabled auto-merge (squash) April 21, 2025 09:38
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 57.11%. Comparing base (a49da86) to head (20b8770).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
ee/tabby-webserver/src/routes/repositories/mod.rs 0.00% 4 Missing ⚠️
ee/tabby-webserver/src/routes/mod.rs 0.00% 2 Missing ⚠️
crates/tabby/src/routes/health.rs 0.00% 1 Missing ⚠️
ee/tabby-webserver/src/axum/websocket.rs 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4178      +/-   ##
==========================================
- Coverage   57.14%   57.11%   -0.03%     
==========================================
  Files         229      229              
  Lines       28880    28892      +12     
==========================================
- Hits        16504    16503       -1     
- Misses      12376    12389      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wsxiaoys wsxiaoys merged commit 9266e3f into main Apr 21, 2025
5 of 8 checks passed
@wsxiaoys wsxiaoys deleted the chore/upgrade-axum-utoipa branch April 21, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants