Bug Report: table.getRowModel().rows returns only 10 rows when depth is 1

[SvenPittelkow]

Bug Report: table.getRowModel().rows returns only 10 rows when depth is 1

Description

When using table.getRowModel().rows, the returned array contains a maximum of 10 rows if the row depth is 1. However, table.getRowModel().rowsById returns the correct number of rows.

Steps to Reproduce

1. Initialize a table with more than 10 rows.
2. Ensure that the row depth is set to 1.
3. Call table.getRowModel().rows.
4. Observe that the returned array contains a maximum of 10 rows.
5. Call table.getRowModel().rowsById and compare the results.

Expected Behavior

table.getRowModel().rows should return all rows, not just a maximum of 10, similar to table.getRowModel().rowsById.

Actual Behavior

Only 10 rows are returned when using table.getRowModel().rows, while table.getRowModel().rowsById returns the full set.

Environment

• Library version: @tanstack/table-core": "8.21.2"
• Browser: Chrome Version 133.0.6943.142 (Offizieller Build) (arm64)
• OS: MacOS

Additional Context

It seems that table.getRowModel().rows might be applying an unintended limit when the row depth is 1.

[SvenPittelkow]

Update: Issue Resolved 🎉

I found the mistake! I was missing the pagination state, which caused only 10 items to be rendered by default.

Solution:

Setting the pagination state correctly ensures that all rows are displayed:

const pagination = useMemo(() => {
    return {
        pageIndex: 0,
        pageSize: data.map((d) => d.subRows?.length ?? 0).reduce((acc, val) => acc + val, 0) + data.length,
    };
}, [data]);

const table = useReactTable({
    data,
    columns,
    enableRowSelection: true,
    state: {
        pagination,
    },

    getRowId: (row) => row.id,
    columnResizeMode: 'onChange',
    getSubRows: (row) => row.subRows,
    getCoreRowModel: getCoreRowModel(),
    getExpandedRowModel: getExpandedRowModel(),
    getPaginationRowModel: getPaginationRowModel(),
});