Skip to content

Commit 39122a9

Browse files
authored
style: include PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS (#6133)
1 parent 779381f commit 39122a9

File tree

2 files changed

+14
-17
lines changed

2 files changed

+14
-17
lines changed

spotbugs-exclude.xml

-3
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@
114114
<Match>
115115
<Bug pattern="BL_BURYING_LOGIC" />
116116
</Match>
117-
<Match>
118-
<Bug pattern="PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS" />
119-
</Match>
120117
<Match>
121118
<Bug pattern="UTWR_USE_TRY_WITH_RESOURCES" />
122119
</Match>

src/main/java/com/thealgorithms/scheduling/SJFScheduling.java

+14-14
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,18 @@ public class SJFScheduling {
1414
protected ArrayList<ProcessDetails> processes;
1515
protected ArrayList<String> schedule;
1616

17+
private static void sortProcessesByArrivalTime(List<ProcessDetails> processes) {
18+
for (int i = 0; i < processes.size(); i++) {
19+
for (int j = i + 1; j < processes.size() - 1; j++) {
20+
if (processes.get(j).getArrivalTime() > processes.get(j + 1).getArrivalTime()) {
21+
final var temp = processes.get(j);
22+
processes.set(j, processes.get(j + 1));
23+
processes.set(j + 1, temp);
24+
}
25+
}
26+
}
27+
}
28+
1729
/**
1830
* a simple constructor
1931
* @param processes a list of processes the user wants to schedule
@@ -22,22 +34,10 @@ public class SJFScheduling {
2234
SJFScheduling(final ArrayList<ProcessDetails> processes) {
2335
this.processes = processes;
2436
schedule = new ArrayList<>();
25-
sortByArrivalTime();
37+
sortProcessesByArrivalTime(this.processes);
2638
}
2739
protected void sortByArrivalTime() {
28-
int size = processes.size();
29-
int i;
30-
int j;
31-
ProcessDetails temp;
32-
for (i = 0; i < size; i++) {
33-
for (j = i + 1; j < size - 1; j++) {
34-
if (processes.get(j).getArrivalTime() > processes.get(j + 1).getArrivalTime()) {
35-
temp = processes.get(j);
36-
processes.set(j, processes.get(j + 1));
37-
processes.set(j + 1, temp);
38-
}
39-
}
40-
}
40+
sortProcessesByArrivalTime(processes);
4141
}
4242

4343
/**

0 commit comments

Comments
 (0)