Skip to content

Commit 46acca1

Browse files
richard-townsend-armTrott
authored andcommitted
build: zlib build error on Windows on Arm
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent adcebfd commit 46acca1

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tools/v8_gypfiles/v8.gyp

+7-1
Original file line numberDiff line numberDiff line change
@@ -1642,7 +1642,13 @@
16421642
'toolsets': ['host', 'target'],
16431643
}],
16441644
['OS=="win"', {
1645-
'defines': ['X86_WINDOWS'],
1645+
'conditions': [
1646+
['"<(target_arch)"=="arm64" and _toolset=="target"', {
1647+
'defines': ['CPU_NO_SIMD']
1648+
}, {
1649+
'defines': ['X86_WINDOWS']
1650+
}]
1651+
]
16461652
}],
16471653
],
16481654
'direct_dependent_settings': {

0 commit comments

Comments
 (0)