Skip to content

Commit 60db588

Browse files
QueueHefnerTrott
authored andcommitted
test: improve test-process-kill-pid
PR-URL: nodejs#12588 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent e8004db commit 60db588

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

test/parallel/test-process-kill-pid.js

+11-7
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,20 @@ const assert = require('assert');
3838
//
3939
// process.pid, String(process.pid): ourself
4040

41-
assert.throws(function() { process.kill('SIGTERM'); }, TypeError);
42-
assert.throws(function() { process.kill(null); }, TypeError);
43-
assert.throws(function() { process.kill(undefined); }, TypeError);
44-
assert.throws(function() { process.kill(+'not a number'); }, TypeError);
45-
assert.throws(function() { process.kill(1 / 0); }, TypeError);
46-
assert.throws(function() { process.kill(-1 / 0); }, TypeError);
41+
assert.throws(function() { process.kill('SIGTERM'); },
42+
/^TypeError: invalid pid$/);
43+
assert.throws(function() { process.kill(null); }, /^TypeError: invalid pid$/);
44+
assert.throws(function() { process.kill(undefined); },
45+
/^TypeError: invalid pid$/);
46+
assert.throws(function() { process.kill(+'not a number'); },
47+
/^TypeError: invalid pid$/);
48+
assert.throws(function() { process.kill(1 / 0); }, /^TypeError: invalid pid$/);
49+
assert.throws(function() { process.kill(-1 / 0); }, /^TypeError: invalid pid$/);
4750

4851
// Test that kill throws an error for invalid signal
4952

50-
assert.throws(function() { process.kill(1, 'test'); }, Error);
53+
assert.throws(function() { process.kill(1, 'test'); },
54+
/^Error: Unknown signal: test$/);
5155

5256
// Test kill argument processing in valid cases.
5357
//

0 commit comments

Comments
 (0)