Skip to content

Commit 6e3da34

Browse files
richard-townsend-armTrott
authored andcommitted
build: zlib build error on Windows on Arm
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 25a2eb0 commit 6e3da34

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tools/v8_gypfiles/v8.gyp

+7-1
Original file line numberDiff line numberDiff line change
@@ -1605,7 +1605,13 @@
16051605
'toolsets': ['host', 'target'],
16061606
}],
16071607
['OS=="win"', {
1608-
'defines': ['X86_WINDOWS'],
1608+
'conditions': [
1609+
['"<(target_arch)"=="arm64" and _toolset=="target"', {
1610+
'defines': ['CPU_NO_SIMD']
1611+
}, {
1612+
'defines': ['X86_WINDOWS']
1613+
}]
1614+
]
16091615
}],
16101616
],
16111617
'direct_dependent_settings': {

0 commit comments

Comments
 (0)