You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I like the API you use as is - it reminds me of what Selenium-Webdriver did for Node.js as well. (Read below).
But I am wondering if this library has plans to move to async/await instead of the homegrown flow control currently used. I like the methodology you used (is there a name for it?) but it's hard to mix other async flow control with your library.
For the record - selenium-webdriver did something similar to this library whereby every (async) call was put on a queue - they moved to promises (which will work with async await of course).
@ORESoftware this module is rarely updated, even useful PRs are pending for a long time so I don't see if you can get that change easily. Anyways you can use newer module - https://github.com/kriasoft/node-sqlite, which uses this one only underneath the hood.
Hey! :)
I like the API you use as is - it reminds me of what Selenium-Webdriver did for Node.js as well. (Read below).
But I am wondering if this library has plans to move to async/await instead of the homegrown flow control currently used. I like the methodology you used (is there a name for it?) but it's hard to mix other async flow control with your library.
For the record - selenium-webdriver did something similar to this library whereby every (async) call was put on a queue - they moved to promises (which will work with async await of course).
You can read about that here:
https://github.com/SeleniumHQ/selenium/wiki/WebDriverJs
and here:
https://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/lib/promise.html
Might be a good excuse to update the lib, or maybe you'd recommend forking it and applying the changes if Mapbox doesn't see a need?
The text was updated successfully, but these errors were encountered: