Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the exclude property #377

Closed
basarat opened this issue Jun 3, 2015 · 9 comments
Closed

Support the exclude property #377

basarat opened this issue Jun 3, 2015 · 9 comments

Comments

@basarat
Copy link
Member

basarat commented Jun 3, 2015

  • Update to latest master
  • Support the property
  • Update the default generated tsconfig to be "exclude" only

microsoft/TypeScript#3188

Need to think about its interaction with filesGlob

@devopsmariocom
Copy link

👍

@basarat
Copy link
Member Author

basarat commented Aug 12, 2015

People have expressed desire to still have filesGlob so I'll wait on this for a while

@nycdotnet
Copy link
Contributor

It seemed that the only reason the TypeScript team went with exclude is that they didn't want to take a dependency on a glob matcher library. It would be a shame to lose this great functionality. I hope filesGlob doesn't have to go away when exclude support is implemented.

@Cu3PO42
Copy link
Member

Cu3PO42 commented Aug 13, 2015

I strongly agree with everyone who likes filesGlob. Even though excludes gives you some of the power, you may want to exclude all TS files in a certain folder and not list them manually. This might be the case if you have copies of a dependency which is subject to change.

@basarat
Copy link
Member Author

basarat commented Aug 13, 2015

Updated issue accordingly 🌹 filesGlob will stay

@Cu3PO42
Copy link
Member

Cu3PO42 commented Aug 14, 2015

I'm very glad to hear that 👍

@basarat
Copy link
Member Author

basarat commented Sep 22, 2015

Up for grabs

Implementor guidance

Source code needs to go here : tsconfig.ts

For guidance one can use the work done here. Basically add the excludes to the pseudo filesGlob.

@tanguylebarzic
Copy link

@basarat Please have a look at #637. I'm happy to work on improving this pull request.

@basarat
Copy link
Member Author

basarat commented Oct 4, 2015

closed with #637

@basarat basarat closed this as completed Oct 4, 2015
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants