Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use norm explicitly #76

Merged
merged 8 commits into from
Feb 14, 2025
Merged

use norm explicitly #76

merged 8 commits into from
Feb 14, 2025

Conversation

cvanelteren
Copy link
Contributor

Should fix #75

@cvanelteren cvanelteren requested a review from beckermr February 14, 2025 09:07
beckermr
beckermr requested changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, we should compare the output figures directly as well.

@cvanelteren
Copy link
Contributor Author

As in make the test an image compare?

@beckermr
Copy link
Collaborator

Yes. It will be a no-op in this case, but will catch any regressions in the future.

@cvanelteren cvanelteren requested a review from beckermr February 14, 2025 12:17
@cvanelteren
Copy link
Contributor Author

The test will fail due to a newly added test (probably).

beckermr
beckermr reviewed Feb 14, 2025
View reviewed changes
@cvanelteren cvanelteren requested a review from beckermr February 14, 2025 12:37
beckermr
beckermr approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failure is indeed expected and correct. LGTM!

@beckermr beckermr merged commit 8cd9a08 into Ultraplot:main Feb 14, 2025
10 of 13 checks passed
@cvanelteren cvanelteren mentioned this pull request Feb 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

norm ignored when (when clipping) for coloring scatter plots; normalizer is modified
2 participants
@cvanelteren @beckermr