diff --git a/Project/Assets/ML-Agents/Examples/3DBall/Scripts/Ball3DHardAgent.cs b/Project/Assets/ML-Agents/Examples/3DBall/Scripts/Ball3DHardAgent.cs index b9dff0d353..ddc335316c 100644 --- a/Project/Assets/ML-Agents/Examples/3DBall/Scripts/Ball3DHardAgent.cs +++ b/Project/Assets/ML-Agents/Examples/3DBall/Scripts/Ball3DHardAgent.cs @@ -1,7 +1,6 @@ using UnityEngine; using Unity.MLAgents; using Unity.MLAgents.Actuators; -using Unity.MLAgents.Sensors; using Unity.MLAgents.Sensors.Reflection; public class Ball3DHardAgent : Agent diff --git a/Project/Assets/ML-Agents/Examples/Basic/Scripts/BasicActuatorComponent.cs b/Project/Assets/ML-Agents/Examples/Basic/Scripts/BasicActuatorComponent.cs index cd019a1424..9a02b6765e 100644 --- a/Project/Assets/ML-Agents/Examples/Basic/Scripts/BasicActuatorComponent.cs +++ b/Project/Assets/ML-Agents/Examples/Basic/Scripts/BasicActuatorComponent.cs @@ -31,7 +31,7 @@ public override ActionSpec ActionSpec /// /// Simple actuator that converts the action into a {-1, 0, 1} direction /// - public class BasicActuator : IActuator, IHeuristicProvider + public class BasicActuator : IActuator { public BasicController basicController; ActionSpec m_ActionSpec; diff --git a/Project/Assets/ML-Agents/Examples/Crawler/Scripts/CrawlerAgent.cs b/Project/Assets/ML-Agents/Examples/Crawler/Scripts/CrawlerAgent.cs index 9a38f1339f..6165c90ba2 100644 --- a/Project/Assets/ML-Agents/Examples/Crawler/Scripts/CrawlerAgent.cs +++ b/Project/Assets/ML-Agents/Examples/Crawler/Scripts/CrawlerAgent.cs @@ -1,6 +1,5 @@ using UnityEngine; using Unity.MLAgents; -using Unity.Barracuda; using Unity.MLAgents.Actuators; using Unity.MLAgentsExamples; using Unity.MLAgents.Sensors; diff --git a/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs b/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs index 5f7c426e39..52c8e57b10 100644 --- a/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs +++ b/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs @@ -1,4 +1,3 @@ -using System.Collections; using UnityEngine; using Unity.MLAgents; using Unity.MLAgents.Sensors; diff --git a/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/SimpleNPC.cs b/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/SimpleNPC.cs index 8887787216..e498fbf425 100644 --- a/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/SimpleNPC.cs +++ b/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/SimpleNPC.cs @@ -1,6 +1,3 @@ -// using System; -using System.Collections; -using System.Collections.Generic; using UnityEngine; public class SimpleNPC : MonoBehaviour diff --git a/Project/Assets/ML-Agents/Examples/FoodCollector/Scripts/FoodCollectorAgent.cs b/Project/Assets/ML-Agents/Examples/FoodCollector/Scripts/FoodCollectorAgent.cs index e9e173e56f..3bb6a07492 100644 --- a/Project/Assets/ML-Agents/Examples/FoodCollector/Scripts/FoodCollectorAgent.cs +++ b/Project/Assets/ML-Agents/Examples/FoodCollector/Scripts/FoodCollectorAgent.cs @@ -105,7 +105,7 @@ public void MoveAgent(ActionBuffers actionBuffers) dirToGo += transform.right * right; rotateDir = -transform.up * rotate; - var shootCommand = (int)discreteActions[0] > 0; + var shootCommand = discreteActions[0] > 0; if (shootCommand) { m_Shoot = true; diff --git a/Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3Agent.cs b/Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3Agent.cs index fb7ab75994..9e03ed5026 100644 --- a/Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3Agent.cs +++ b/Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3Agent.cs @@ -1,8 +1,6 @@ using System; using UnityEngine; using Unity.MLAgents; -using Unity.MLAgents.Actuators; -using Unity.MLAgents.Integrations.Match3; namespace Unity.MLAgentsExamples { diff --git a/Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3ExampleActuator.cs b/Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3ExampleActuator.cs index a277635a3f..d54e824df0 100644 --- a/Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3ExampleActuator.cs +++ b/Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3ExampleActuator.cs @@ -1,4 +1,3 @@ -using Unity.MLAgents; using Unity.MLAgents.Integrations.Match3; namespace Unity.MLAgentsExamples diff --git a/Project/Assets/ML-Agents/Examples/PushBlock/Scripts/GoalDetectTrigger.cs b/Project/Assets/ML-Agents/Examples/PushBlock/Scripts/GoalDetectTrigger.cs index 369ac66f68..baa5efe75a 100644 --- a/Project/Assets/ML-Agents/Examples/PushBlock/Scripts/GoalDetectTrigger.cs +++ b/Project/Assets/ML-Agents/Examples/PushBlock/Scripts/GoalDetectTrigger.cs @@ -1,5 +1,3 @@ -using System.Collections; -using System.Collections.Generic; using UnityEngine; using UnityEngine.Events; diff --git a/Project/Assets/ML-Agents/Examples/PushBlock/Scripts/PushAgentCollab.cs b/Project/Assets/ML-Agents/Examples/PushBlock/Scripts/PushAgentCollab.cs index fd2fe5fd72..5c00eecd14 100644 --- a/Project/Assets/ML-Agents/Examples/PushBlock/Scripts/PushAgentCollab.cs +++ b/Project/Assets/ML-Agents/Examples/PushBlock/Scripts/PushAgentCollab.cs @@ -1,6 +1,4 @@ //Put this script on your blue cube. - -using System.Collections; using UnityEngine; using Unity.MLAgents; using Unity.MLAgents.Actuators; diff --git a/Project/Assets/ML-Agents/Examples/PushBlockWithInput/Scripts/PushBlockWithInputAgentBasic.cs b/Project/Assets/ML-Agents/Examples/PushBlockWithInput/Scripts/PushBlockWithInputAgentBasic.cs index 61a3eeba30..57072e7456 100644 --- a/Project/Assets/ML-Agents/Examples/PushBlockWithInput/Scripts/PushBlockWithInputAgentBasic.cs +++ b/Project/Assets/ML-Agents/Examples/PushBlockWithInput/Scripts/PushBlockWithInputAgentBasic.cs @@ -1,6 +1,4 @@ //Put this script on your blue cube. - -using System; using System.Collections; using UnityEngine; using Unity.MLAgents; @@ -18,7 +16,7 @@ public class PushBlockWithInputAgentBasic : Agent /// /// The area bounds. - /// + /// [HideInInspector] public Bounds areaBounds; diff --git a/Project/Assets/ML-Agents/Examples/SharedAssets/Scripts/CollisionCallbacks.cs b/Project/Assets/ML-Agents/Examples/SharedAssets/Scripts/CollisionCallbacks.cs index 4a5d6425fd..c9a26bfc8c 100644 --- a/Project/Assets/ML-Agents/Examples/SharedAssets/Scripts/CollisionCallbacks.cs +++ b/Project/Assets/ML-Agents/Examples/SharedAssets/Scripts/CollisionCallbacks.cs @@ -1,6 +1,4 @@ using UnityEngine; -using Random = UnityEngine.Random; -using Unity.MLAgents; using UnityEngine.Events; namespace Unity.MLAgentsExamples diff --git a/Project/Assets/ML-Agents/Examples/Soccer/Scripts/SoccerEnvController.cs b/Project/Assets/ML-Agents/Examples/Soccer/Scripts/SoccerEnvController.cs index 7eb60b360e..5eccf3522d 100644 --- a/Project/Assets/ML-Agents/Examples/Soccer/Scripts/SoccerEnvController.cs +++ b/Project/Assets/ML-Agents/Examples/Soccer/Scripts/SoccerEnvController.cs @@ -1,4 +1,3 @@ -using System.Collections; using System.Collections.Generic; using Unity.MLAgents; using UnityEngine; @@ -91,7 +90,7 @@ public void ResetBall() var randomPosX = Random.Range(-2.5f, 2.5f); var randomPosZ = Random.Range(-2.5f, 2.5f); - ball.transform.position = m_BallStartingPos + new Vector3(randomPosX, 0f, randomPosZ); ; + ball.transform.position = m_BallStartingPos + new Vector3(randomPosX, 0f, randomPosZ); ballRb.velocity = Vector3.zero; ballRb.angularVelocity = Vector3.zero; diff --git a/Project/Assets/ML-Agents/Examples/Sorter/Scripts/NumberTile.cs b/Project/Assets/ML-Agents/Examples/Sorter/Scripts/NumberTile.cs index 0041890cc0..f1f80a8f4a 100644 --- a/Project/Assets/ML-Agents/Examples/Sorter/Scripts/NumberTile.cs +++ b/Project/Assets/ML-Agents/Examples/Sorter/Scripts/NumberTile.cs @@ -1,5 +1,3 @@ -using System.Collections; -using System.Collections.Generic; using UnityEngine; public class NumberTile : MonoBehaviour @@ -8,7 +6,7 @@ public class NumberTile : MonoBehaviour public Material DefaultMaterial; public Material SuccessMaterial; - private bool m_Visited = false; + private bool m_Visited; private MeshRenderer m_Renderer; public bool IsVisited diff --git a/Project/Assets/ML-Agents/Examples/Sorter/Scripts/SorterAgent.cs b/Project/Assets/ML-Agents/Examples/Sorter/Scripts/SorterAgent.cs index c74b6e3f19..a2cdb51612 100644 --- a/Project/Assets/ML-Agents/Examples/Sorter/Scripts/SorterAgent.cs +++ b/Project/Assets/ML-Agents/Examples/Sorter/Scripts/SorterAgent.cs @@ -81,7 +81,7 @@ public override void CollectObservations(VectorSensor sensor) // Here, the observation for the tile is added to the BufferSensor m_BufferSensor.AppendObservation(listObservation); - }; + } } diff --git a/Project/Assets/ML-Agents/Examples/Walker/Scripts/WalkerAgent.cs b/Project/Assets/ML-Agents/Examples/Walker/Scripts/WalkerAgent.cs index 7a3120017a..c0177ec0dd 100644 --- a/Project/Assets/ML-Agents/Examples/Walker/Scripts/WalkerAgent.cs +++ b/Project/Assets/ML-Agents/Examples/Walker/Scripts/WalkerAgent.cs @@ -261,7 +261,6 @@ void FixedUpdate() Vector3 GetAvgVelocity() { Vector3 velSum = Vector3.zero; - Vector3 avgVel = Vector3.zero; //ALL RBS int numOfRb = 0; @@ -271,7 +270,7 @@ Vector3 GetAvgVelocity() velSum += item.rb.velocity; } - avgVel = velSum / numOfRb; + var avgVel = velSum / numOfRb; return avgVel; } diff --git a/Project/Assets/ML-Agents/Examples/Worm/Scripts/WormAgent.cs b/Project/Assets/ML-Agents/Examples/Worm/Scripts/WormAgent.cs index 5dd5daf450..6a5c2044bc 100644 --- a/Project/Assets/ML-Agents/Examples/Worm/Scripts/WormAgent.cs +++ b/Project/Assets/ML-Agents/Examples/Worm/Scripts/WormAgent.cs @@ -1,6 +1,5 @@ using UnityEngine; using Unity.MLAgents; -using Unity.Barracuda; using Unity.MLAgents.Actuators; using Unity.MLAgentsExamples; using Unity.MLAgents.Sensors; diff --git a/com.unity.ml-agents.extensions/Runtime/Input/Adaptors/ButtonInputActionAdaptor.cs b/com.unity.ml-agents.extensions/Runtime/Input/Adaptors/ButtonInputActionAdaptor.cs index 230bb65c57..b37582422a 100644 --- a/com.unity.ml-agents.extensions/Runtime/Input/Adaptors/ButtonInputActionAdaptor.cs +++ b/com.unity.ml-agents.extensions/Runtime/Input/Adaptors/ButtonInputActionAdaptor.cs @@ -1,6 +1,5 @@ #if MLA_INPUT_SYSTEM using Unity.MLAgents.Actuators; -using UnityEngine; using UnityEngine.InputSystem; using UnityEngine.InputSystem.Controls; using UnityEngine.InputSystem.LowLevel; diff --git a/com.unity.ml-agents.extensions/Runtime/Input/Adaptors/Vector2InputActionAdaptor.cs b/com.unity.ml-agents.extensions/Runtime/Input/Adaptors/Vector2InputActionAdaptor.cs index e12f15b4c0..744b894b72 100644 --- a/com.unity.ml-agents.extensions/Runtime/Input/Adaptors/Vector2InputActionAdaptor.cs +++ b/com.unity.ml-agents.extensions/Runtime/Input/Adaptors/Vector2InputActionAdaptor.cs @@ -1,9 +1,7 @@ #if MLA_INPUT_SYSTEM -using System; using Unity.MLAgents.Actuators; using UnityEngine; using UnityEngine.InputSystem; -using UnityEngine.InputSystem.Controls; using UnityEngine.InputSystem.LowLevel; namespace Unity.MLAgents.Extensions.Input diff --git a/com.unity.ml-agents.extensions/Runtime/Input/IRLActionInputAdaptor.cs b/com.unity.ml-agents.extensions/Runtime/Input/IRLActionInputAdaptor.cs index 1f3a12e64a..c0f1ade2fb 100644 --- a/com.unity.ml-agents.extensions/Runtime/Input/IRLActionInputAdaptor.cs +++ b/com.unity.ml-agents.extensions/Runtime/Input/IRLActionInputAdaptor.cs @@ -1,5 +1,4 @@ #if MLA_INPUT_SYSTEM -using System; using Unity.MLAgents.Actuators; using UnityEngine.InputSystem; using UnityEngine.InputSystem.LowLevel; diff --git a/com.unity.ml-agents.extensions/Runtime/Input/InputActionActuator.cs b/com.unity.ml-agents.extensions/Runtime/Input/InputActionActuator.cs index cfb1012f1c..4a6ecd4e41 100644 --- a/com.unity.ml-agents.extensions/Runtime/Input/InputActionActuator.cs +++ b/com.unity.ml-agents.extensions/Runtime/Input/InputActionActuator.cs @@ -2,7 +2,6 @@ using Unity.MLAgents.Actuators; using Unity.MLAgents.Policies; -using UnityEngine; using UnityEngine.InputSystem; using UnityEngine.Profiling; diff --git a/com.unity.ml-agents.extensions/Tests/Runtime/Input/Adaptors/IntegerInputActionAdaptorTests.cs b/com.unity.ml-agents.extensions/Tests/Runtime/Input/Adaptors/IntegerInputActionAdaptorTests.cs index fe29e85d74..a6d92e7af2 100644 --- a/com.unity.ml-agents.extensions/Tests/Runtime/Input/Adaptors/IntegerInputActionAdaptorTests.cs +++ b/com.unity.ml-agents.extensions/Tests/Runtime/Input/Adaptors/IntegerInputActionAdaptorTests.cs @@ -1,9 +1,7 @@ #if MLA_INPUT_TESTS -using System; using NUnit.Framework; using Unity.MLAgents.Actuators; using Unity.MLAgents.Extensions.Input; -using UnityEngine; using UnityEngine.InputSystem; namespace Unity.MLAgents.Extensions.Tests.Runtime.Input diff --git a/com.unity.ml-agents.extensions/Tests/Runtime/Sensors/CountingGridSensorTests.cs b/com.unity.ml-agents.extensions/Tests/Runtime/Sensors/CountingGridSensorTests.cs index b4acb43609..fe0b71423d 100644 --- a/com.unity.ml-agents.extensions/Tests/Runtime/Sensors/CountingGridSensorTests.cs +++ b/com.unity.ml-agents.extensions/Tests/Runtime/Sensors/CountingGridSensorTests.cs @@ -133,7 +133,7 @@ public void TestCountingSensor() gridSensor.Update(); - subarrayIndicies = new int[] { 77, 78, 87, 88 }; + subarrayIndicies = new[] { 77, 78, 87, 88 }; expectedSubarrays = DuplicateArray(new float[] { 2, 0 }, 4); expectedDefault = new float[] { 0, 0 }; AssertSubarraysAtIndex(gridSensor.PerceptionBuffer, subarrayIndicies, expectedSubarrays, expectedDefault); diff --git a/com.unity.ml-agents.extensions/Tests/Runtime/Sensors/RigidBodySensorTests.cs b/com.unity.ml-agents.extensions/Tests/Runtime/Sensors/RigidBodySensorTests.cs index 68300be98f..2e1a6fb81b 100644 --- a/com.unity.ml-agents.extensions/Tests/Runtime/Sensors/RigidBodySensorTests.cs +++ b/com.unity.ml-agents.extensions/Tests/Runtime/Sensors/RigidBodySensorTests.cs @@ -1,4 +1,3 @@ -using System.Runtime.CompilerServices; using UnityEngine; using NUnit.Framework; using Unity.MLAgents.Sensors; diff --git a/com.unity.ml-agents/Editor/DemonstrationDrawer.cs b/com.unity.ml-agents/Editor/DemonstrationDrawer.cs index 35de8ed569..d15baa9a1d 100644 --- a/com.unity.ml-agents/Editor/DemonstrationDrawer.cs +++ b/com.unity.ml-agents/Editor/DemonstrationDrawer.cs @@ -2,8 +2,6 @@ using System.Text; using UnityEditor; using Unity.MLAgents.Demonstrations; -using Unity.MLAgents.Policies; - namespace Unity.MLAgents.Editor { diff --git a/com.unity.ml-agents/Runtime/Actuators/ActionSpec.cs b/com.unity.ml-agents/Runtime/Actuators/ActionSpec.cs index ee7ff53a98..6b0a001a7d 100644 --- a/com.unity.ml-agents/Runtime/Actuators/ActionSpec.cs +++ b/com.unity.ml-agents/Runtime/Actuators/ActionSpec.cs @@ -1,5 +1,4 @@ using System; -using System.Collections.Generic; using System.Linq; using UnityEngine; diff --git a/com.unity.ml-agents/Runtime/Actuators/ActuatorComponent.cs b/com.unity.ml-agents/Runtime/Actuators/ActuatorComponent.cs index 215267992c..af34bef3a3 100644 --- a/com.unity.ml-agents/Runtime/Actuators/ActuatorComponent.cs +++ b/com.unity.ml-agents/Runtime/Actuators/ActuatorComponent.cs @@ -1,4 +1,3 @@ -using System; using UnityEngine; namespace Unity.MLAgents.Actuators diff --git a/com.unity.ml-agents/Runtime/Actuators/IDiscreteActionMask.cs b/com.unity.ml-agents/Runtime/Actuators/IDiscreteActionMask.cs index a11dc13502..e7ac7e60f3 100644 --- a/com.unity.ml-agents/Runtime/Actuators/IDiscreteActionMask.cs +++ b/com.unity.ml-agents/Runtime/Actuators/IDiscreteActionMask.cs @@ -1,5 +1,3 @@ -using System.Collections.Generic; - namespace Unity.MLAgents.Actuators { /// diff --git a/com.unity.ml-agents/Runtime/Analytics/InferenceAnalytics.cs b/com.unity.ml-agents/Runtime/Analytics/InferenceAnalytics.cs index 1e735ada66..4286aa844d 100644 --- a/com.unity.ml-agents/Runtime/Analytics/InferenceAnalytics.cs +++ b/com.unity.ml-agents/Runtime/Analytics/InferenceAnalytics.cs @@ -31,7 +31,7 @@ internal class InferenceAnalytics /// /// Whether or not we've registered this particular event yet /// - static bool s_EventRegistered = false; + static bool s_EventRegistered; /// /// Hourly limit for this event name diff --git a/com.unity.ml-agents/Runtime/Analytics/TrainingAnalytics.cs b/com.unity.ml-agents/Runtime/Analytics/TrainingAnalytics.cs index 1168b7c4d0..fb14e1bab7 100644 --- a/com.unity.ml-agents/Runtime/Analytics/TrainingAnalytics.cs +++ b/com.unity.ml-agents/Runtime/Analytics/TrainingAnalytics.cs @@ -47,7 +47,7 @@ internal static class TrainingAnalytics /// /// Whether or not we've registered this particular event yet /// - static bool s_EventsRegistered = false; + static bool s_EventsRegistered; /// /// Behaviors that we've already sent events for. diff --git a/com.unity.ml-agents/Runtime/Communicator/GrpcExtensions.cs b/com.unity.ml-agents/Runtime/Communicator/GrpcExtensions.cs index 812efe7e46..760d5e6b25 100644 --- a/com.unity.ml-agents/Runtime/Communicator/GrpcExtensions.cs +++ b/com.unity.ml-agents/Runtime/Communicator/GrpcExtensions.cs @@ -24,7 +24,7 @@ internal static class GrpcExtensions /// /// Static flag to make sure that we only fire the warning once. /// - private static bool s_HaveWarnedTrainerCapabilitiesAgentGroup = false; + private static bool s_HaveWarnedTrainerCapabilitiesAgentGroup; /// /// Converts a AgentInfo to a protobuf generated AgentInfoActionPairProto @@ -326,8 +326,8 @@ public static ActionBuffers ToActionBuffers(this AgentActionProto proto) /// /// Static flag to make sure that we only fire the warning once. /// - private static bool s_HaveWarnedTrainerCapabilitiesMultiPng = false; - private static bool s_HaveWarnedTrainerCapabilitiesMapping = false; + private static bool s_HaveWarnedTrainerCapabilitiesMultiPng; + private static bool s_HaveWarnedTrainerCapabilitiesMapping; /// /// Generate an ObservationProto for the sensor using the provided ObservationWriter. diff --git a/com.unity.ml-agents/Runtime/DecisionRequester.cs b/com.unity.ml-agents/Runtime/DecisionRequester.cs index 50a489010c..424046d523 100644 --- a/com.unity.ml-agents/Runtime/DecisionRequester.cs +++ b/com.unity.ml-agents/Runtime/DecisionRequester.cs @@ -14,7 +14,7 @@ namespace Unity.MLAgents /// /// The DecisionRequester component provides a convenient and flexible way to /// trigger the agent decision making process. Without a DecisionRequester, - /// your implmentation must manually call its + /// your implementation must manually call its /// function. /// [AddComponentMenu("ML Agents/Decision Requester", (int)MenuGroup.Default)] diff --git a/com.unity.ml-agents/Runtime/Inference/BarracudaModelExtensions.cs b/com.unity.ml-agents/Runtime/Inference/BarracudaModelExtensions.cs index fc2e3a0168..a76fe06d91 100644 --- a/com.unity.ml-agents/Runtime/Inference/BarracudaModelExtensions.cs +++ b/com.unity.ml-agents/Runtime/Inference/BarracudaModelExtensions.cs @@ -251,8 +251,7 @@ public static bool HasDiscreteOutputs(this Model model) } else { - return model.outputs.Contains(TensorNames.DiscreteActionOutput) && - (int)model.DiscreteOutputSize() > 0; + return model.outputs.Contains(TensorNames.DiscreteActionOutput) && model.DiscreteOutputSize() > 0; } } diff --git a/com.unity.ml-agents/Runtime/Inference/GeneratorImpl.cs b/com.unity.ml-agents/Runtime/Inference/GeneratorImpl.cs index 2d290538b3..b76833c490 100644 --- a/com.unity.ml-agents/Runtime/Inference/GeneratorImpl.cs +++ b/com.unity.ml-agents/Runtime/Inference/GeneratorImpl.cs @@ -1,6 +1,5 @@ using System.Collections.Generic; using System; -using UnityEngine; using Unity.Barracuda; using Unity.MLAgents.Inference.Utils; using Unity.MLAgents.Sensors; diff --git a/com.unity.ml-agents/Runtime/Inference/ModelRunner.cs b/com.unity.ml-agents/Runtime/Inference/ModelRunner.cs index 054ac2ac4e..5b4699e564 100644 --- a/com.unity.ml-agents/Runtime/Inference/ModelRunner.cs +++ b/com.unity.ml-agents/Runtime/Inference/ModelRunner.cs @@ -1,4 +1,3 @@ -using System; using System.Collections.Generic; using Unity.Barracuda; using UnityEngine.Profiling; diff --git a/com.unity.ml-agents/Runtime/InplaceArray.cs b/com.unity.ml-agents/Runtime/InplaceArray.cs index 6e45cb1cfb..91208136d8 100644 --- a/com.unity.ml-agents/Runtime/InplaceArray.cs +++ b/com.unity.ml-agents/Runtime/InplaceArray.cs @@ -29,9 +29,9 @@ public InplaceArray(T elem0) { m_Length = 1; m_Elem0 = elem0; - m_Elem1 = new T { }; - m_Elem2 = new T { }; - m_Elem3 = new T { }; + m_Elem1 = new T(); + m_Elem2 = new T(); + m_Elem3 = new T(); } /// @@ -44,8 +44,8 @@ public InplaceArray(T elem0, T elem1) m_Length = 2; m_Elem0 = elem0; m_Elem1 = elem1; - m_Elem2 = new T { }; - m_Elem3 = new T { }; + m_Elem2 = new T(); + m_Elem3 = new T(); } /// @@ -60,7 +60,7 @@ public InplaceArray(T elem0, T elem1, T elem2) m_Elem0 = elem0; m_Elem1 = elem1; m_Elem2 = elem2; - m_Elem3 = new T { }; + m_Elem3 = new T(); } /// diff --git a/com.unity.ml-agents/Runtime/Integrations/Match3/Move.cs b/com.unity.ml-agents/Runtime/Integrations/Match3/Move.cs index 3e3da800fa..20bf0809bc 100644 --- a/com.unity.ml-agents/Runtime/Integrations/Match3/Move.cs +++ b/com.unity.ml-agents/Runtime/Integrations/Match3/Move.cs @@ -75,7 +75,7 @@ public static Move FromMoveIndex(int moveIndex, BoardSize maxBoardSize) if (moveIndex < 0 || moveIndex >= NumPotentialMoves(maxBoardSize)) { - throw new ArgumentOutOfRangeException("Invalid move index."); + throw new ArgumentOutOfRangeException("moveIndex"); } Direction dir; int row, col; diff --git a/com.unity.ml-agents/Runtime/MLAgentsSettingsManager.cs b/com.unity.ml-agents/Runtime/MLAgentsSettingsManager.cs index 0befbb3939..2c54593497 100644 --- a/com.unity.ml-agents/Runtime/MLAgentsSettingsManager.cs +++ b/com.unity.ml-agents/Runtime/MLAgentsSettingsManager.cs @@ -1,8 +1,9 @@ using System; -using System.Linq; using UnityEngine; #if UNITY_EDITOR using UnityEditor; +#else +using System.Linq; #endif namespace Unity.MLAgents diff --git a/com.unity.ml-agents/Runtime/MultiAgentGroupIdCounter.cs b/com.unity.ml-agents/Runtime/MultiAgentGroupIdCounter.cs index 95670171d0..47aa61299e 100644 --- a/com.unity.ml-agents/Runtime/MultiAgentGroupIdCounter.cs +++ b/com.unity.ml-agents/Runtime/MultiAgentGroupIdCounter.cs @@ -7,7 +7,7 @@ internal static class MultiAgentGroupIdCounter static int s_Counter; public static int GetGroupId() { - return Interlocked.Increment(ref s_Counter); ; + return Interlocked.Increment(ref s_Counter); } } } diff --git a/com.unity.ml-agents/Runtime/Policies/HeuristicPolicy.cs b/com.unity.ml-agents/Runtime/Policies/HeuristicPolicy.cs index b18956833a..8e5333874a 100644 --- a/com.unity.ml-agents/Runtime/Policies/HeuristicPolicy.cs +++ b/com.unity.ml-agents/Runtime/Policies/HeuristicPolicy.cs @@ -22,7 +22,6 @@ internal class HeuristicPolicy : IPolicy NullList m_NullList = new NullList(); - /// public HeuristicPolicy(ActuatorManager actuatorManager, ActionSpec actionSpec) { m_ActuatorManager = actuatorManager; diff --git a/com.unity.ml-agents/Runtime/Policies/RemotePolicy.cs b/com.unity.ml-agents/Runtime/Policies/RemotePolicy.cs index 8c9230f3c2..faa8a37e60 100644 --- a/com.unity.ml-agents/Runtime/Policies/RemotePolicy.cs +++ b/com.unity.ml-agents/Runtime/Policies/RemotePolicy.cs @@ -26,7 +26,6 @@ internal class RemotePolicy : IPolicy /// private IList m_Actuators; - /// public RemotePolicy( ActionSpec actionSpec, IList actuators, diff --git a/com.unity.ml-agents/Runtime/Sensors/BoxOverlapChecker.cs b/com.unity.ml-agents/Runtime/Sensors/BoxOverlapChecker.cs index 7a6f0f5310..93029722b2 100644 --- a/com.unity.ml-agents/Runtime/Sensors/BoxOverlapChecker.cs +++ b/com.unity.ml-agents/Runtime/Sensors/BoxOverlapChecker.cs @@ -83,7 +83,7 @@ void InitCellLocalPositions() /// Converts the index of the cell to the 3D point (y is zero) relative to grid center /// Vector3 of the position of the center of the cell relative to grid center - /// The index of the cell + /// The index of the cell Vector3 GetCellLocalPosition(int cellIndex) { float x = (cellIndex / m_GridSize.z - m_CellCenterOffset.x) * m_CellScale.x; diff --git a/com.unity.ml-agents/Runtime/Sensors/GridSensorComponent.cs b/com.unity.ml-agents/Runtime/Sensors/GridSensorComponent.cs index 034809729b..a423825e57 100644 --- a/com.unity.ml-agents/Runtime/Sensors/GridSensorComponent.cs +++ b/com.unity.ml-agents/Runtime/Sensors/GridSensorComponent.cs @@ -4,7 +4,7 @@ namespace Unity.MLAgents.Sensors { /// - /// A SensorComponent that creates a . + /// A SensorComponent that creates a . /// [AddComponentMenu("ML Agents/Grid Sensor", (int)MenuGroup.Sensors)] public class GridSensorComponent : SensorComponent diff --git a/com.unity.ml-agents/Runtime/Sensors/ISensor.cs b/com.unity.ml-agents/Runtime/Sensors/ISensor.cs index 2038520f62..17fe074684 100644 --- a/com.unity.ml-agents/Runtime/Sensors/ISensor.cs +++ b/com.unity.ml-agents/Runtime/Sensors/ISensor.cs @@ -1,13 +1,12 @@ using System; using System.Collections.Generic; -using System.Linq; namespace Unity.MLAgents.Sensors { /// /// The Dimension property flags of the observations /// - [System.Flags] + [Flags] public enum DimensionProperty { /// diff --git a/com.unity.ml-agents/Runtime/Sensors/ObservationSpec.cs b/com.unity.ml-agents/Runtime/Sensors/ObservationSpec.cs index 9ebbb388af..59c7f2eb4e 100644 --- a/com.unity.ml-agents/Runtime/Sensors/ObservationSpec.cs +++ b/com.unity.ml-agents/Runtime/Sensors/ObservationSpec.cs @@ -1,5 +1,3 @@ -using Unity.Barracuda; - namespace Unity.MLAgents.Sensors { /// diff --git a/com.unity.ml-agents/Runtime/Sensors/RenderTextureSensor.cs b/com.unity.ml-agents/Runtime/Sensors/RenderTextureSensor.cs index 1734c513c9..678e722220 100644 --- a/com.unity.ml-agents/Runtime/Sensors/RenderTextureSensor.cs +++ b/com.unity.ml-agents/Runtime/Sensors/RenderTextureSensor.cs @@ -107,9 +107,6 @@ public BuiltInSensorType GetBuiltInSensorType() /// Texture2D to render to. public static void ObservationToTexture(RenderTexture obsTexture, Texture2D texture2D) { - var height = obsTexture.height; - var width = obsTexture.width; - var prevActiveRt = RenderTexture.active; RenderTexture.active = obsTexture; diff --git a/com.unity.ml-agents/Runtime/Sensors/SensorComponent.cs b/com.unity.ml-agents/Runtime/Sensors/SensorComponent.cs index 38781eec7b..4ddcaabb74 100644 --- a/com.unity.ml-agents/Runtime/Sensors/SensorComponent.cs +++ b/com.unity.ml-agents/Runtime/Sensors/SensorComponent.cs @@ -1,5 +1,4 @@ using UnityEngine; -using System; namespace Unity.MLAgents.Sensors { diff --git a/com.unity.ml-agents/Runtime/Sensors/StackingSensor.cs b/com.unity.ml-agents/Runtime/Sensors/StackingSensor.cs index 645fe120e6..407f96b009 100644 --- a/com.unity.ml-agents/Runtime/Sensors/StackingSensor.cs +++ b/com.unity.ml-agents/Runtime/Sensors/StackingSensor.cs @@ -1,6 +1,5 @@ using System; using System.Linq; -using System.Runtime.CompilerServices; using UnityEngine; using Unity.Barracuda; diff --git a/com.unity.ml-agents/Runtime/Sensors/VectorSensor.cs b/com.unity.ml-agents/Runtime/Sensors/VectorSensor.cs index 37eb052289..eda3ea4d1d 100644 --- a/com.unity.ml-agents/Runtime/Sensors/VectorSensor.cs +++ b/com.unity.ml-agents/Runtime/Sensors/VectorSensor.cs @@ -1,4 +1,3 @@ -using System; using System.Collections.Generic; using System.Collections.ObjectModel; using UnityEngine; diff --git a/com.unity.ml-agents/Runtime/Sensors/VectorSensorComponent.cs b/com.unity.ml-agents/Runtime/Sensors/VectorSensorComponent.cs index abd8bb09f5..73edf6e155 100644 --- a/com.unity.ml-agents/Runtime/Sensors/VectorSensorComponent.cs +++ b/com.unity.ml-agents/Runtime/Sensors/VectorSensorComponent.cs @@ -1,5 +1,4 @@ using UnityEngine; -using UnityEngine.Serialization; namespace Unity.MLAgents.Sensors { diff --git a/com.unity.ml-agents/Runtime/SideChannels/TrainingAnalyticsSideChannel.cs b/com.unity.ml-agents/Runtime/SideChannels/TrainingAnalyticsSideChannel.cs index b30f5b821c..0c880e4be9 100644 --- a/com.unity.ml-agents/Runtime/SideChannels/TrainingAnalyticsSideChannel.cs +++ b/com.unity.ml-agents/Runtime/SideChannels/TrainingAnalyticsSideChannel.cs @@ -1,5 +1,4 @@ using System; -using UnityEngine; using Unity.MLAgents.Analytics; using Unity.MLAgents.CommunicatorObjects; diff --git a/com.unity.ml-agents/Runtime/SimpleMultiAgentGroup.cs b/com.unity.ml-agents/Runtime/SimpleMultiAgentGroup.cs index 4398918f4f..c5fe6ce835 100644 --- a/com.unity.ml-agents/Runtime/SimpleMultiAgentGroup.cs +++ b/com.unity.ml-agents/Runtime/SimpleMultiAgentGroup.cs @@ -59,7 +59,7 @@ public int GetId() /// public IReadOnlyCollection GetRegisteredAgents() { - return (IReadOnlyCollection)m_Agents; + return m_Agents; } /// diff --git a/com.unity.ml-agents/Tests/Editor/AcademyTests.cs b/com.unity.ml-agents/Tests/Editor/AcademyTests.cs index 593197295d..eaf32befdc 100644 --- a/com.unity.ml-agents/Tests/Editor/AcademyTests.cs +++ b/com.unity.ml-agents/Tests/Editor/AcademyTests.cs @@ -1,8 +1,6 @@ using NUnit.Framework; using Unity.MLAgents.Sensors; using UnityEngine; -using System.Reflection; -using Unity.MLAgents; namespace Unity.MLAgents.Tests { diff --git a/com.unity.ml-agents/Tests/Editor/Actuators/ActionSpecTests.cs b/com.unity.ml-agents/Tests/Editor/Actuators/ActionSpecTests.cs index 78c4fbeff8..09dfd33670 100644 --- a/com.unity.ml-agents/Tests/Editor/Actuators/ActionSpecTests.cs +++ b/com.unity.ml-agents/Tests/Editor/Actuators/ActionSpecTests.cs @@ -1,10 +1,7 @@ -using System; using System.Collections.Generic; using System.Linq; using NUnit.Framework; using Unity.MLAgents.Actuators; -using UnityEngine.TestTools.Constraints; -using Is = UnityEngine.TestTools.Constraints.Is; namespace Unity.MLAgents.Tests.Actuators { diff --git a/com.unity.ml-agents/Tests/Editor/Actuators/TestActuator.cs b/com.unity.ml-agents/Tests/Editor/Actuators/TestActuator.cs index 31ba0bf28e..f4d32708f1 100644 --- a/com.unity.ml-agents/Tests/Editor/Actuators/TestActuator.cs +++ b/com.unity.ml-agents/Tests/Editor/Actuators/TestActuator.cs @@ -1,7 +1,7 @@ using Unity.MLAgents.Actuators; namespace Unity.MLAgents.Tests.Actuators { - internal class TestActuator : IActuator, IHeuristicProvider + internal class TestActuator : IActuator { public ActionBuffers LastActionBuffer; public int[][] Masks; diff --git a/com.unity.ml-agents/Tests/Editor/Communicator/GrpcExtensionsTests.cs b/com.unity.ml-agents/Tests/Editor/Communicator/GrpcExtensionsTests.cs index d3767d2783..34bd3caaea 100644 --- a/com.unity.ml-agents/Tests/Editor/Communicator/GrpcExtensionsTests.cs +++ b/com.unity.ml-agents/Tests/Editor/Communicator/GrpcExtensionsTests.cs @@ -1,7 +1,6 @@ using System; using System.Text.RegularExpressions; using Google.Protobuf; -using Google.Protobuf.Collections; using NUnit.Framework; using Unity.MLAgents.Actuators; using Unity.MLAgents.Demonstrations; @@ -158,10 +157,6 @@ class DummySensor : ISensor public ObservationSpec ObservationSpec; public SensorCompressionType CompressionType; - internal DummySensor() - { - } - public ObservationSpec GetObservationSpec() { return ObservationSpec; diff --git a/com.unity.ml-agents/Tests/Editor/Inference/EditModeTestInternalBrainTensorGenerator.cs b/com.unity.ml-agents/Tests/Editor/Inference/EditModeTestInternalBrainTensorGenerator.cs index ff98d7ea32..579a204c4b 100644 --- a/com.unity.ml-agents/Tests/Editor/Inference/EditModeTestInternalBrainTensorGenerator.cs +++ b/com.unity.ml-agents/Tests/Editor/Inference/EditModeTestInternalBrainTensorGenerator.cs @@ -5,7 +5,6 @@ using Unity.MLAgents.Actuators; using Unity.MLAgents.Inference; using Unity.MLAgents.Policies; -using Unity.MLAgents.Sensors.Reflection; using Unity.MLAgents.Utils.Tests; namespace Unity.MLAgents.Tests diff --git a/com.unity.ml-agents/Tests/Editor/InplaceArrayTests.cs b/com.unity.ml-agents/Tests/Editor/InplaceArrayTests.cs index 0c6e63666c..2e8f21cf28 100644 --- a/com.unity.ml-agents/Tests/Editor/InplaceArrayTests.cs +++ b/com.unity.ml-agents/Tests/Editor/InplaceArrayTests.cs @@ -1,8 +1,6 @@ using System; using System.Collections; using NUnit.Framework; -using Unity.MLAgents; -using UnityEngine; namespace Unity.MLAgents.Tests diff --git a/com.unity.ml-agents/Tests/Editor/Integrations/Match3/Match3SensorTests.cs b/com.unity.ml-agents/Tests/Editor/Integrations/Match3/Match3SensorTests.cs index 6c1eaa61d9..26c5416cfa 100644 --- a/com.unity.ml-agents/Tests/Editor/Integrations/Match3/Match3SensorTests.cs +++ b/com.unity.ml-agents/Tests/Editor/Integrations/Match3/Match3SensorTests.cs @@ -5,7 +5,6 @@ using UnityEngine; using Unity.MLAgents.Integrations.Match3; using Unity.MLAgents.Sensors; -using Unity.MLAgents.Tests; namespace Unity.MLAgents.Tests.Integrations.Match3 { diff --git a/com.unity.ml-agents/Tests/Editor/MultiAgentGroupTests.cs b/com.unity.ml-agents/Tests/Editor/MultiAgentGroupTests.cs index 965b71acfd..5d987d55df 100644 --- a/com.unity.ml-agents/Tests/Editor/MultiAgentGroupTests.cs +++ b/com.unity.ml-agents/Tests/Editor/MultiAgentGroupTests.cs @@ -1,9 +1,7 @@ -using Unity.MLAgents; using System; using System.Reflection; using NUnit.Framework; using UnityEngine; -using Unity; namespace Unity.MLAgents.Tests { diff --git a/com.unity.ml-agents/Tests/Editor/Policies/HeuristicPolicyTest.cs b/com.unity.ml-agents/Tests/Editor/Policies/HeuristicPolicyTest.cs index 944b7ff907..740f6a1a6b 100644 --- a/com.unity.ml-agents/Tests/Editor/Policies/HeuristicPolicyTest.cs +++ b/com.unity.ml-agents/Tests/Editor/Policies/HeuristicPolicyTest.cs @@ -41,7 +41,7 @@ static void CheckAndSetBuffer(in ActionBuffers actionsOut) class ActionClearedAgent : Agent { - public int HeuristicCalls = 0; + public int HeuristicCalls; public override void Heuristic(in ActionBuffers actionsOut) { CheckAndSetBuffer(actionsOut); @@ -51,7 +51,7 @@ public override void Heuristic(in ActionBuffers actionsOut) class ActionClearedActuator : IActuator { - public int HeuristicCalls = 0; + public int HeuristicCalls; public ActionClearedActuator(ActionSpec actionSpec) { ActionSpec = actionSpec; diff --git a/com.unity.ml-agents/Tests/Editor/PublicAPI/PublicApiValidation.cs b/com.unity.ml-agents/Tests/Editor/PublicAPI/PublicApiValidation.cs index f3635b64a7..44b22d9c11 100644 --- a/com.unity.ml-agents/Tests/Editor/PublicAPI/PublicApiValidation.cs +++ b/com.unity.ml-agents/Tests/Editor/PublicAPI/PublicApiValidation.cs @@ -1,4 +1,3 @@ -using System.Collections.Generic; using Unity.MLAgents.Sensors; using NUnit.Framework; using Unity.MLAgents; diff --git a/com.unity.ml-agents/Tests/Editor/TimerTest.cs b/com.unity.ml-agents/Tests/Editor/TimerTest.cs index a2da0fdc69..58fc048c91 100644 --- a/com.unity.ml-agents/Tests/Editor/TimerTest.cs +++ b/com.unity.ml-agents/Tests/Editor/TimerTest.cs @@ -1,5 +1,4 @@ using NUnit.Framework; -using UnityEngine; namespace Unity.MLAgents.Tests { diff --git a/com.unity.ml-agents/Tests/Runtime/Sensor/BoxOverlapCheckerTests.cs b/com.unity.ml-agents/Tests/Runtime/Sensor/BoxOverlapCheckerTests.cs index 5f5651c0c5..7884414434 100644 --- a/com.unity.ml-agents/Tests/Runtime/Sensor/BoxOverlapCheckerTests.cs +++ b/com.unity.ml-agents/Tests/Runtime/Sensor/BoxOverlapCheckerTests.cs @@ -194,7 +194,7 @@ public void TestParseCollidersClosest() gridSizeX: 2, gridSizeZ: 2, rootReference: testGo, - detectableTags: new string[] { tag1 }); + detectableTags: new [] { tag1 }); var helper = new VerifyParseCollidersHelper(); boxOverlap.GridOverlapDetectedClosest += helper.DetectedAction; @@ -230,7 +230,7 @@ public void TestParseCollidersAll() gridSizeX: 2, gridSizeZ: 2, rootReference: testGo, - detectableTags: new string[] { tag1 }); + detectableTags: new [] { tag1 }); var helper = new VerifyParseCollidersHelper(); boxOverlap.GridOverlapDetectedAll += helper.DetectedAction; diff --git a/com.unity.ml-agents/Tests/Runtime/Sensor/BufferSensorTest.cs b/com.unity.ml-agents/Tests/Runtime/Sensor/BufferSensorTest.cs index 622c238695..fc0935d1de 100644 --- a/com.unity.ml-agents/Tests/Runtime/Sensor/BufferSensorTest.cs +++ b/com.unity.ml-agents/Tests/Runtime/Sensor/BufferSensorTest.cs @@ -1,4 +1,3 @@ -using System; using NUnit.Framework; using UnityEngine; using Unity.MLAgents.Sensors; diff --git a/com.unity.ml-agents/Tests/Runtime/Sensor/CameraSensorTest.cs b/com.unity.ml-agents/Tests/Runtime/Sensor/CameraSensorTest.cs index 7dc9c42fde..3a0bd17746 100644 --- a/com.unity.ml-agents/Tests/Runtime/Sensor/CameraSensorTest.cs +++ b/com.unity.ml-agents/Tests/Runtime/Sensor/CameraSensorTest.cs @@ -2,7 +2,6 @@ using NUnit.Framework; using UnityEngine; using Unity.MLAgents.Sensors; -using Object = System.Object; namespace Unity.MLAgents.Tests { diff --git a/com.unity.ml-agents/Tests/Runtime/Sensor/RayPerceptionSensorTests.cs b/com.unity.ml-agents/Tests/Runtime/Sensor/RayPerceptionSensorTests.cs index a4c7badc59..5dad4f4cb1 100644 --- a/com.unity.ml-agents/Tests/Runtime/Sensor/RayPerceptionSensorTests.cs +++ b/com.unity.ml-agents/Tests/Runtime/Sensor/RayPerceptionSensorTests.cs @@ -1,4 +1,3 @@ -using System; using System.Collections.Generic; using NUnit.Framework; using UnityEngine; diff --git a/com.unity.ml-agents/Tests/Runtime/Sensor/SensorUtilTests.cs b/com.unity.ml-agents/Tests/Runtime/Sensor/SensorUtilTests.cs index 0fe45897ba..e186f800c4 100644 --- a/com.unity.ml-agents/Tests/Runtime/Sensor/SensorUtilTests.cs +++ b/com.unity.ml-agents/Tests/Runtime/Sensor/SensorUtilTests.cs @@ -2,7 +2,6 @@ using System.Collections.Generic; using System.Globalization; using NUnit.Framework; -using UnityEngine; using Unity.MLAgents.Sensors; using Unity.MLAgents.Utils.Tests; diff --git a/com.unity.ml-agents/Tests/Runtime/Sensor/StackingSensorTests.cs b/com.unity.ml-agents/Tests/Runtime/Sensor/StackingSensorTests.cs index df5644e999..8aaa1fcfc3 100644 --- a/com.unity.ml-agents/Tests/Runtime/Sensor/StackingSensorTests.cs +++ b/com.unity.ml-agents/Tests/Runtime/Sensor/StackingSensorTests.cs @@ -119,10 +119,6 @@ class Dummy3DSensor : ISensor public ObservationSpec ObservationSpec; public float[,,] CurrentObservation; - internal Dummy3DSensor() - { - } - public ObservationSpec GetObservationSpec() { return ObservationSpec;