Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong contents for 1.1.2 in npm #18

Closed
cburgmer opened this issue Jul 20, 2017 · 1 comment
Closed

Wrong contents for 1.1.2 in npm #18

cburgmer opened this issue Jul 20, 2017 · 1 comment

Comments

@cburgmer
Copy link

To reproduce:

$ mkdir from_source
$ cd from_source
$ git clone https://github.com/VadimDez/ngx-img-fallback.git
$ cd ngx-img-fallback
$ git checkout 1.1.2
$ npm install
$ npm run build
$ cd ../..
$ mkdir from_npm
$ cd from_npm
$ curl -O https://registry.npmjs.org/ngx-img-fallback/-/ngx-img-fallback-1.1.2.tgz
$ tar -xzf ngx-img-fallback-1.1.2.tgz
$ diff package/dist/bundles/ngx-img-fallback.umd.js ../from_source/ngx-img-fallback/dist/bundles/ngx-img-fallback.umd.js
23,24c23,25
<         this.el.addEventListener(this.ERROR_EVENT_TYPE, this.onError.bind(this));
<         this.el.addEventListener(this.LOAD_EVENT_TYPE, this.onLoad.bind(this));
---
>         this.onError = this.onError.bind(this);
>         this.onLoad = this.onLoad.bind(this);
>         this.addEvents();
26c27
<     ImgFallbackDirective.prototype.onError = function () {
---
>     ImgFallbackDirective.prototype.ngOnDestroy = function () {
28c29,32
<         if (!this.isApplied) {
---
>         this.removeOnLoadEvent();
>     };
>     ImgFallbackDirective.prototype.onError = function () {
>         if (this.el.getAttribute('src') !== this.imgSrc) {
43,45c47,49
<     ImgFallbackDirective.prototype.ngOnDestroy = function () {
<         this.removeErrorEvent();
<         this.removeOnLoadEvent();
---
>     ImgFallbackDirective.prototype.addEvents = function () {
>         this.el.addEventListener(this.ERROR_EVENT_TYPE, this.onError);
>         this.el.addEventListener(this.LOAD_EVENT_TYPE, this.onLoad);
55c59
<     __metadata("design:type", _angular_core.EventEmitter)
---
>     __metadata("design:type", Object)
@cburgmer
Copy link
Author

Please republish under 1.1.3 preferably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants