Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Please add a @NgModule annotation in 1.3.0 #24

Closed
ClemensSchneider opened this issue Feb 2, 2018 · 4 comments
Closed

Error: Please add a @NgModule annotation in 1.3.0 #24

ClemensSchneider opened this issue Feb 2, 2018 · 4 comments
Assignees
Milestone

Comments

@ClemensSchneider
Copy link

Seems like the latest 1.3.0 release is missing some metadata as I get the following error:

ERROR in : Unexpected value 'ImgFallbackModule in <path-to-project>/node_modules/ngx-img-fallback/src/app/modules/ngx-img-fallback/ngx-img-fallback.module.d.ts' imported by the module 'SharedModule in <path-to-project>/src/app/shared/shared.module.ts'. Please add a @NgModule annotation.

Downgrading to 1.2.0 fixes this issue.

@VadimDez
Copy link
Owner

VadimDez commented Feb 2, 2018

Are you using ng-cli?
Or wha's your setup?
Which angular version?

@ClemensSchneider
Copy link
Author

Angular CLI: 1.6.7
Node: 8.7.0
OS: win32 x64
Angular: 5.2.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cdk: 5.1.1
@angular/cli: 1.6.7
@angular/material: 5.1.1
@angular-devkit/build-optimizer: 0.0.42
@angular-devkit/core: 0.0.29
@angular-devkit/schematics: 0.0.52
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.7
@schematics/angular: 0.1.17
typescript: 2.6.2
webpack: 3.10.0

@ClemensSchneider
Copy link
Author

But same with @angular 5.0.0, cli 1.5.5:

Angular CLI: 1.5.5
Node: 8.7.0
OS: win32 x64
Angular: 5.0.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cdk: 5.0.1
@angular/cli: 1.5.5
@angular/material: 5.0.1
@angular-devkit/build-optimizer: 0.0.36
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.42
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.8.5
@schematics/angular: 0.1.11
@schematics/schematics: 0.0.11
typescript: 2.4.2
webpack: 3.8.1

@VadimDez VadimDez self-assigned this Feb 2, 2018
@VadimDez VadimDez added this to the 1.3.1 milestone Feb 2, 2018
@VadimDez
Copy link
Owner

VadimDez commented Feb 2, 2018

The issue is fixed in 1.3.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants