Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast issue in CloudSeed.Native/MultitapDiffuser.h #9

Open
EleonoreMizo opened this issue Dec 1, 2020 · 0 comments
Open

Cast issue in CloudSeed.Native/MultitapDiffuser.h #9

EleonoreMizo opened this issue Dec 1, 2020 · 0 comments

Comments

@EleonoreMizo
Copy link

Hi, I wanted to check the formula you used in CloudSeed to generate the early reflection taps. In MultitapDiffuser::Update(), there is a formula double tapCountFactor = 1.0 / (1 + std::sqrt(count / MaxTaps));. But it seems both count and MaxTaps are integer, so the division is done in integer land and returns 0 most of the times. Maybe casting count to double beforehand would give a more expected result?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant