Cleaned all warnings in Core, .Blazor project + minor suggestions (#62)

Cleaned up warnings and code suggestions

Author: snakex64

src/.editorconfig

@@ -51,15 +51,15 @@ dotnet_style_operator_placement_when_wrapping = beginning_of_line
 tab_width = 4
 indent_size = 4
 end_of_line = crlf
-dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_coalesce_expression = false:suggestion
 dotnet_style_null_propagation = true:suggestion
 dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
 dotnet_style_prefer_auto_properties = true:silent
 dotnet_style_object_initializer = true:suggestion
 dotnet_style_collection_initializer = true:suggestion
 dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
-dotnet_style_prefer_conditional_expression_over_assignment = true:suggestion
-dotnet_style_prefer_conditional_expression_over_return = true:suggestion
+dotnet_style_prefer_conditional_expression_over_assignment = false:suggestion
+dotnet_style_prefer_conditional_expression_over_return = false:suggestion
 dotnet_style_explicit_tuple_names = true:suggestion
 dotnet_style_prefer_inferred_tuple_names = true:suggestion
 dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
@@ -69,6 +69,9 @@ dotnet_style_prefer_collection_expression = when_types_loosely_match:suggestion
 dotnet_style_namespace_match_folder = true:suggestion
 indent_style = tab
 
+# Code Quality
+dotnet_code_quality.CA1826.exclude_ordefault_methods = true
+
 [*.cs]
 csharp_indent_labels = one_less_than_current
 csharp_space_around_binary_operators = before_and_after
@@ -78,7 +81,7 @@ csharp_prefer_braces = true:silent
 csharp_style_namespace_declarations = block_scoped:silent
 csharp_style_prefer_method_group_conversion = true:silent
 csharp_style_prefer_top_level_statements = true:silent
-csharp_style_prefer_primary_constructors = true:suggestion
+csharp_style_prefer_primary_constructors = false:suggestion
 csharp_prefer_system_threading_lock = true:suggestion
 csharp_style_expression_bodied_methods = false:silent
 csharp_style_expression_bodied_constructors = false:silent

src/NodeDev.Blazor/Components/ClassExplorer.razor

@@ -202,9 +202,9 @@
             }).Result;
 
         NodeDev.Core.Types.TypeBase typeBase;
-        if (result.Data is Type type)
+        if (result?.Data is Type type)
             typeBase = Class.TypeFactory.Get(type, null);
-        else if (result.Data is NodeDev.Core.Types.TypeBase t)
+        else if (result?.Data is NodeDev.Core.Types.TypeBase t)
             typeBase = t;
         else
             return;
@@ -234,7 +234,7 @@
         {
             if (CurrentlyEditingItem!.Type == TreeItemType.Method)
             {
-                var method = new Core.Class.NodeClassMethod(Class, Text, Class.TypeFactory.Get(typeof(void), null), new Core.Graph());
+                var method = new Core.Class.NodeClassMethod(Class, Text, Class.TypeFactory.Get(typeof(void), null));
                 Class.AddMethod(method, createEntryAndReturn: true);
 
                 Items.First(x => x.Value!.Type == TreeItemType.MethodsFolder).Children!.RemoveAll(x => x.Value == CurrentlyEditingItem);

src/NodeDev.Blazor/Components/DebuggerConsolePanel.razor.cs

@@ -78,6 +78,8 @@ private void AddText(string text)
 
 	public void Dispose()
 	{
+		GC.SuppressFinalize(this);
+
 		GraphExecutionChangedDisposable?.Dispose();
 		RefreshRequiredDisposable?.Dispose();
 

src/NodeDev.Blazor/Components/EditMethodMenu.razor

@@ -19,15 +19,15 @@
                         </CellTemplate>
                     </TemplateColumn>
 
-                    <CallbackSetColumn Property="x => x.Name" SetCallback="(x, name) => x.Rename(name)" IsEditable="true" />
+                    <CallbackSetColumn Property="x => x.Name" SetCallback="(x, name) => x.Rename(name)" Editable="true" />
 
                     <TemplateColumn Title="IsOut">
                         <EditTemplate>
                             <MudCheckBox T="bool" Value="context.Item?.IsOut ?? false" ValueChanged="@(v => context.Item?.SetIsOut(v))"></MudCheckBox>
                         </EditTemplate>
                     </TemplateColumn>
 
-                    <TemplateColumn IsEditable="false">
+                    <TemplateColumn Editable="false">
 
                         <CellTemplate>
 
@@ -73,9 +73,9 @@
             }).Result;
 
         NodeDev.Core.Types.TypeBase typeBase;
-        if (result.Data is Type type)
+        if (result?.Data is Type type)
             typeBase = Method.Class.TypeFactory.Get(type, null);
-        else if (result.Data is NodeDev.Core.Types.TypeBase t)
+        else if (result?.Data is NodeDev.Core.Types.TypeBase t)
             typeBase = t;
         else
             return;