Skip to content

Commit 2729f08

Browse files
authored
Merge pull request grpc#23170 from lidizheng/setup-extras
Add protobuf as an "extras" dependency to grpcio package
2 parents c342345 + b5ec43e commit 2729f08

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

requirements.bazel.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
coverage>=4.0
33
cython>=0.29.8
44
enum34>=1.0.4
5-
protobuf>=3.5.0.post1
5+
protobuf>=3.5.0.post1, < 4.0dev
66
six>=1.10
77
wheel>=0.29
88
futures>=2.2.0

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
coverage>=4.0
33
cython>=0.29.8
44
enum34>=1.0.4
5-
protobuf>=3.5.0.post1
5+
protobuf>=3.5.0.post1, < 4.0dev
66
six>=1.10
77
wheel>=0.29

setup.py

+4
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,9 @@ def cython_extensions_and_necessity():
355355
"futures>=2.2.0; python_version<'3.2'",
356356
"enum34>=1.0.4; python_version<'3.4'",
357357
)
358+
EXTRAS_REQUIRES = {
359+
'protobuf': 'grpcio-tools>={version}'.format(version=grpc_version.VERSION),
360+
}
358361

359362
SETUP_REQUIRES = INSTALL_REQUIRES + (
360363
'Sphinx~=1.8.1',
@@ -417,6 +420,7 @@ def cython_extensions_and_necessity():
417420
package_dir=PACKAGE_DIRECTORIES,
418421
package_data=PACKAGE_DATA,
419422
install_requires=INSTALL_REQUIRES,
423+
extras_require=EXTRAS_REQUIRES,
420424
setup_requires=SETUP_REQUIRES,
421425
cmdclass=COMMAND_CLASS,
422426
)

tools/distrib/python/grpcio_tools/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ def extension_modules():
219219
ext_modules=extension_modules(),
220220
packages=setuptools.find_packages('.'),
221221
install_requires=[
222-
'protobuf>=3.5.0.post1',
222+
'protobuf>=3.5.0.post1, < 4.0dev',
223223
'grpcio>={version}'.format(version=grpc_version.VERSION),
224224
],
225225
package_data=package_data(),

0 commit comments

Comments
 (0)