Skip to content
This repository was archived by the owner on Jan 26, 2023. It is now read-only.

Commit 3994d85

Browse files
authoredMar 18, 2020
Try: Graduate all Gutenberg icons to the icon font. (#402)
Helps fix WordPress/gutenberg#20003. Back in the day when we moved from a manual process, to a build script for Dashicons, we put Gutenberg icons in a separate folder that was not included in the icon font. The context for that started in a meeting here: https://wordpress.slack.com/archives/C03EESJAW/p1498836928887730 — this meeting outlined the process of creating a trac ticket for every icon created and approved separately. Some of that process is outlined in https://wordpress.slack.com/archives/C03EESJAW/p1498838219357464. In order to stay nimble and allow us to move fast with creating Gutenberg icons, it was suggested (https://wordpress.slack.com/archives/C03EESJAW/p1498838530476355) to put Gutenberg icons in a separte folder that is not included in the icon font, landing only in the React component. But the icons have been there for a bit now, and in effort to fix #20003, these icons now need to graduate. Because of their time in the editor, it feels fair to review them all in a single ticket.
1 parent 3c2dc45 commit 3994d85

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+519
-15
lines changed
 

‎Gruntfile.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ module.exports = function( grunt ) {
7070
},
7171
},
7272

73-
// Generate a web font, omit Gutenberg files for now, as they need separate approval
73+
// Generate a web font.
7474
webfont: {
7575
icons: {
7676
src: 'svg-min/*.svg',

‎codepoints.json

+27-3
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@
241241
"trash": 61826,
242242
"heading": 61710,
243243
"insert": 61711,
244-
"saved": 61715,
245244
"align-full-width": 61716,
246245
"button": 61722,
247246
"align-wide": 61723,
@@ -259,7 +258,6 @@
259258
"admin-site-alt": 61725,
260259
"admin-site-alt2": 61726,
261260
"admin-site-alt3": 61727,
262-
"html": 61729,
263261
"rest-api": 61732,
264262
"yes-alt": 61738,
265263
"buddicons-bbpress-logo": 62583,
@@ -278,5 +276,31 @@
278276
"plugins-checked": 62597,
279277
"text-page": 61729,
280278
"update-alt": 61715,
281-
"code-standards": 61754
279+
"code-standards": 61754,
280+
"align-pull-left": 61706,
281+
"align-pull-right": 61707,
282+
"block-default": 61739,
283+
"cloud-saved": 61751,
284+
"cloud-upload": 61755,
285+
"columns": 61756,
286+
"cover-image": 61757,
287+
"embed-audio": 61758,
288+
"embed-generic": 61759,
289+
"embed-photo": 61764,
290+
"embed-post": 61766,
291+
"embed-video": 61769,
292+
"exit": 61770,
293+
"html": 61771,
294+
"info-outline": 61772,
295+
"insert-after": 61773,
296+
"insert-before": 61774,
297+
"remove": 61775,
298+
"shortcode": 61776,
299+
"table-col-after": 61777,
300+
"table-col-before": 61778,
301+
"table-col-delete": 61786,
302+
"table-row-after": 61787,
303+
"table-row-before": 61788,
304+
"table-row-delete": 61789,
305+
"saved": 61790
282306
}

0 commit comments

Comments
 (0)
This repository has been archived.