Skip to content

Commit 8f8e78b

Browse files
committedNov 13, 2021
Disable terminal logging on Windows
Work around rust-lang/rust#88576 until the fix lands in stable.
1 parent 0b4a4ed commit 8f8e78b

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed
 

‎src/utils/mod.rs

+10-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use std::sync::Once;
99

1010
use git_version::git_version;
1111
use log::logger;
12-
use simplelog::{CombinedLogger, LevelFilter, SharedLogger, TermLogger, WriteLogger};
12+
use simplelog::{CombinedLogger, LevelFilter, SharedLogger, WriteLogger};
1313

1414
pub mod marker;
1515
pub use marker::*;
@@ -64,12 +64,20 @@ fn setup_logging_hooks() {
6464
.set_time_format_str("%F %T%.3f")
6565
.set_time_to_local(true)
6666
.build();
67-
let mut logger: Vec<Box<(dyn SharedLogger + 'static)>> = vec![TermLogger::new(
67+
68+
// https://github.com/rust-lang/rust/issues/88576
69+
// In Rust 1.56 terminal logging on Windows causes panics. Disable it until the fix lands in
70+
// stable.
71+
#[cfg(windows)]
72+
let mut logger: Vec<Box<(dyn SharedLogger + 'static)>> = vec![];
73+
#[cfg(not(windows))]
74+
let mut logger: Vec<Box<(dyn SharedLogger + 'static)>> = vec![simplelog::TermLogger::new(
6875
LevelFilter::Trace,
6976
config.clone(),
7077
simplelog::TerminalMode::Stderr,
7178
simplelog::ColorChoice::Auto,
7279
)];
80+
7381
if let Ok(log_file) = OpenOptions::new()
7482
.append(true)
7583
.create(true)

0 commit comments

Comments
 (0)
Please sign in to comment.