Skip to content

HTTP requests ignore tls: false attribute #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattheworiordan opened this issue Nov 19, 2015 · 1 comment
Closed

HTTP requests ignore tls: false attribute #166

mattheworiordan opened this issue Nov 19, 2015 · 1 comment
Assignees
@SimonWoolf
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@mattheworiordan
Copy link
Member

Initialising a Realtime library with tls: false connects to a realtime end point correctly not using TLS, however when performing the following I found the client library attempted to connect over TLS:

  • Implicit token request for auth
  • History requests on a channel

We need to ensure that tls: false is respected for REST operations performed by a Realtime client and add suitable test coverage.

@SimonWoolf mind taking a look?
@mattheworiordan mattheworiordan added the bug Something isn't working. It's clear that this does need to be fixed. label Nov 19, 2015
@SimonWoolf SimonWoolf mentioned this issue Nov 19, 2015
Merged
@SimonWoolf
Copy link
Member

TBH I'd always assumed that was deliberate - rest.baseUri has always ignored the tls option. I've done a PR to change it #167, but will wait for @paddybyers to weigh in on whether there's a reason it was done that way before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonWoolf SimonWoolf

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @SimonWoolf