Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test client library with explicit binary protocol in JSBin #18

Closed
mattheworiordan opened this issue Mar 10, 2015 · 4 comments
Closed

Test client library with explicit binary protocol in JSBin #18

mattheworiordan opened this issue Mar 10, 2015 · 4 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@mattheworiordan
Copy link
Member

Previously we had issues with websocket binary payloads so we need to test that this is no longer an issue

@mattheworiordan mattheworiordan added the bug Something isn't working. It's clear that this does need to be fixed. label Mar 10, 2015
@mattheworiordan mattheworiordan added the failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. label Aug 21, 2015
@SimonWoolf
Copy link
Member

@mattheworiordan do you remember any particular jsbins had problems?

@mattheworiordan
Copy link
Member Author

Nope, can't remember, I just know that for a period we had to explicitly disable the binary protocol in the browser because it was failing frequently.

@paddybyers
Copy link
Member

@SimonWoolf: can you try something explicitly in jsbin (binary, force both websocket and non-websocket transports) ?

@SimonWoolf
Copy link
Member

Tested it a bunch (using this js-bin on latest new-upgrade branch against dev-realtime), but couldn't see any differences between useBinaryProtocol true or false, on any transport, with various setting combinations.

(Did find one behaviour difference between jsbin and normal: with jsbin you get an exception if you use web_socket transport with tls:false and useTokenAuth: true. But unrelated to this so filing a new bug for it).

(don't think there's any difference with current prod either, but had difficulty consistently getting a successful connection anyway due to various other errors (see slack), so hard to be certain)

Closing this until we see this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Development

No branches or pull requests

3 participants