Connection issues

[mattheworiordan]

@paddybyers I am a bit confused why http://jsbin.com/vuvozisape/1/edit?js,console,output is not working.

Seemingly it will only connect when using the format Ably.Realtime({ key: "key" }), and all other key & token formats fail for different reasons.

I also thought we had changed our libraries to support the use of a a key or token string in place of the constructor options which too doesn't seem to be working.

Can we ensure we add test coverage to this once resolved?

[paddybyers]

This is fixed:
2ad36b1

we support

Realtime({key: <key>})
Realtime({authToken: <token>})
Realtime(<key>)
Realtime(<token>)

I've added tests for the string-only cases for realtime and rest

[mattheworiordan]

No tests to prevent a regression?

[mattheworiordan]

Also, is this deployed so I can retry the JSBin?

[paddybyers]

No tests to prevent a regression?

I added tests, as stated above

[paddybyers]

Also, is this deployed so I can retry the JSBin?

Not yet

[mattheworiordan]

Can't see any tests in the commit you sent? Given 3 out of 4 were failing, should we not add coverage to all? Can you deploy please so that we can test this + the other auth issue in production and then in CI for the web server?

[paddybyers]

Can't see any tests in the commit you sent?

79848f8

Given 3 out of 4 were failing, should we not add coverage to all?

2 were failing (tests above), 1 was being used incorrectly (token: xx instead of authToken: xx).

[mattheworiordan]

Ah, great, shout when this and other fixes are deployed so that we can test.

[mattheworiordan]

Unfortunately there is another bug, if you pass in an API key without the form key: 'key' then the client tries to connect over HTTP. See https://jsbin.ably.io/ogizus/3/edit which works, and https://jsbin.ably.io/ogizus/2/edit which fails.

[paddybyers]

This should fix it: c458536

[mattheworiordan]

I see that's tagged 0.7.5, is that deployed?
Hate to be a stickler, but no test to prevent a regression?

[paddybyers]

I see that's tagged 0.7.5, is that deployed?

Yes

Hate to be a stickler, but no test to prevent a regression?

e1f0e89

[paddybyers]

Resolved

[mattheworiordan]

Thanks