Skip to content

Commit 7714682

Browse files
committed
Bump minimal and recommended Android NDK version to 25b
1 parent 25483d6 commit 7714682

File tree

4 files changed

+5
-23
lines changed

4 files changed

+5
-23
lines changed

.github/workflows/push.yml

-18
Original file line numberDiff line numberDiff line change
@@ -109,17 +109,11 @@ jobs:
109109
target: testapps-with-numpy
110110
- name: webview
111111
target: testapps-webview
112-
include:
113-
- runs_on: macos-latest
114-
ndk_version: '23b'
115-
- runs_on: apple-silicon-m1
116-
ndk_version: '24'
117112
env:
118113
ANDROID_HOME: ${HOME}/.android
119114
ANDROID_SDK_ROOT: ${HOME}/.android/android-sdk
120115
ANDROID_SDK_HOME: ${HOME}/.android/android-sdk
121116
ANDROID_NDK_HOME: ${HOME}/.android/android-ndk
122-
ANDROID_NDK_VERSION: ${{ matrix.ndk_version }}
123117
steps:
124118
- name: Checkout python-for-android
125119
uses: actions/checkout@v2
@@ -247,17 +241,11 @@ jobs:
247241
target: testapps-with-numpy-aab
248242
- name: webview
249243
target: testapps-webview-aab
250-
include:
251-
- runs_on: macos-latest
252-
ndk_version: '23b'
253-
- runs_on: apple-silicon-m1
254-
ndk_version: '24'
255244
env:
256245
ANDROID_HOME: ${HOME}/.android
257246
ANDROID_SDK_ROOT: ${HOME}/.android/android-sdk
258247
ANDROID_SDK_HOME: ${HOME}/.android/android-sdk
259248
ANDROID_NDK_HOME: ${HOME}/.android/android-ndk
260-
ANDROID_NDK_VERSION: ${{ matrix.ndk_version }}
261249
steps:
262250
- name: Checkout python-for-android
263251
uses: actions/checkout@v2
@@ -330,18 +318,12 @@ jobs:
330318
matrix:
331319
android_arch: ["arm64-v8a", "armeabi-v7a", "x86_64", "x86"]
332320
runs_on: [macos-latest, apple-silicon-m1]
333-
include:
334-
- runs_on: macos-latest
335-
ndk_version: '23b'
336-
- runs_on: apple-silicon-m1
337-
ndk_version: '24'
338321
env:
339322
ANDROID_HOME: ${HOME}/.android
340323
ANDROID_SDK_ROOT: ${HOME}/.android/android-sdk
341324
ANDROID_SDK_HOME: ${HOME}/.android/android-sdk
342325
ANDROID_NDK_HOME: ${HOME}/.android/android-ndk
343326
REBUILD_UPDATED_RECIPES_EXTRA_ARGS: --arch=${{ matrix.android_arch }}
344-
ANDROID_NDK_VERSION: ${{ matrix.ndk_version }}
345327
steps:
346328
- name: Checkout python-for-android
347329
uses: actions/checkout@v2

ci/makefiles/android.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Downloads and installs the Android SDK depending on supplied platform: darwin or linux
22

33
# Those android NDK/SDK variables can be override when running the file
4-
ANDROID_NDK_VERSION ?= 23b
4+
ANDROID_NDK_VERSION ?= 25b
55
ANDROID_NDK_VERSION_LEGACY ?= 21e
66
ANDROID_SDK_TOOLS_VERSION ?= 6514223
77
ANDROID_SDK_BUILD_TOOLS_VERSION ?= 29.0.3

doc/source/quickstart.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ named ``tools``, and you will need to run extra commands to install
120120
the SDK packages needed.
121121

122122
For Android NDK, note that modern releases will only work on a 64-bit
123-
operating system. **The minimal, and recommended, NDK version to use is r23b:**
123+
operating system. **The minimal, and recommended, NDK version to use is r25b:**
124124

125125
- `Go to ndk downloads page <https://developer.android.com/ndk/downloads/>`_
126126
- Windows users should create a virtual machine with an GNU Linux os

pythonforandroid/recommendations.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
from pythonforandroid.util import BuildInterruptingException
99

1010
# We only check the NDK major version
11-
MIN_NDK_VERSION = 23
12-
MAX_NDK_VERSION = 23
11+
MIN_NDK_VERSION = 25
12+
MAX_NDK_VERSION = 25
1313

1414
# DO NOT CHANGE LINE FORMAT: buildozer parses the existence of a RECOMMENDED_NDK_VERSION
15-
RECOMMENDED_NDK_VERSION = "23b"
15+
RECOMMENDED_NDK_VERSION = "25b"
1616

1717
NDK_DOWNLOAD_URL = "https://developer.android.com/ndk/downloads/"
1818

0 commit comments

Comments
 (0)