Skip to content

Commit 603cf56

Browse files
feat: allow existing logger from context (#859)
We should reuse an existing context logger if available. This will allow test to setup act with a null logger to assert log messages. Co-authored-by: Björn Brauer <[email protected]> Co-authored-by: Björn Brauer <[email protected]>
1 parent cd24df5 commit 603cf56

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

pkg/runner/logger.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,14 @@ func WithJobLogger(ctx context.Context, jobName string, secrets map[string]strin
4747
formatter.insecureSecrets = insecureSecrets
4848
nextColor++
4949

50-
logger := logrus.New()
50+
var logger *logrus.Logger
51+
fieldLogger := common.Logger(ctx)
52+
if fieldLogger != nil {
53+
logger = fieldLogger.(*logrus.Logger)
54+
}
55+
if logger == nil {
56+
logger = logrus.New()
57+
}
5158
logger.SetFormatter(formatter)
5259
logger.SetOutput(os.Stdout)
5360
logger.SetLevel(logrus.GetLevel())

0 commit comments

Comments
 (0)