Skip to content

Commit 3cc9e41

Browse files
taglialatagliala
authored
Add RuboCop performance (#884)
* Add RuboCop performance * Fix safe offenses in non-production code - Performance/RegexpMatch - Performance/StringIdentifierArgument * Fix safe offenses in production code - Performance/BlockGivenWithExplicitBlock - Performance/RegexpMatch - Performance/ReverseEach - Performance/StringReplacement * Fix unsafe offenses in non-production code - Performance/StringInclude * Fix unsafe offenses in production code - Performance/RedundantMerge * Test singleton belongs to helper Use the helper instead of passing the `singleton: true` option for multiple test cases.
1 parent 8f4f445 commit 3cc9e41

File tree

11 files changed

+274
-124
lines changed

11 files changed

+274
-124
lines changed

‎.rubocop.yml

+161
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
---
22

3+
require:
4+
- rubocop-performance
5+
36
AllCops:
47
DisabledByDefault: true
58

@@ -43,5 +46,163 @@ Layout/TrailingWhitespace:
4346
Layout/TrailingEmptyLines:
4447
Enabled: true
4548

49+
Performance:
50+
Enabled: true
51+
52+
Performance/AncestorsInclude:
53+
Enabled: false
54+
55+
Performance/ArraySemiInfiniteRangeSlice:
56+
Enabled: false
57+
58+
Performance/BigDecimalWithNumericArgument:
59+
Enabled: true
60+
61+
Performance/BindCall:
62+
Enabled: true
63+
64+
Performance/BlockGivenWithExplicitBlock:
65+
Enabled: true
66+
67+
Performance/Caller:
68+
Enabled: true
69+
70+
Performance/CaseWhenSplat:
71+
Enabled: true
72+
73+
Performance/Casecmp:
74+
Enabled: false
75+
76+
Performance/ChainArrayAllocation:
77+
Enabled: false
78+
79+
Performance/CollectionLiteralInLoop:
80+
Enabled: true
81+
Exclude:
82+
- spec/**/*
83+
84+
Performance/CompareWithBlock:
85+
Enabled: true
86+
87+
Performance/ConcurrentMonotonicTime:
88+
Enabled: true
89+
90+
Performance/ConstantRegexp:
91+
Enabled: true
92+
93+
Performance/Count:
94+
Enabled: true
95+
96+
Performance/DeletePrefix:
97+
Enabled: true
98+
99+
Performance/DeleteSuffix:
100+
Enabled: true
101+
102+
Performance/Detect:
103+
Enabled: true
104+
105+
Performance/DoubleStartEndWith:
106+
Enabled: true
107+
IncludeActiveSupportAliases: true
108+
109+
Performance/EndWith:
110+
Enabled: true
111+
112+
Performance/FixedSize:
113+
Enabled: true
114+
115+
Performance/FlatMap:
116+
Enabled: true
117+
EnabledForFlattenWithoutParams: false
118+
119+
Performance/InefficientHashSearch:
120+
Enabled: true
121+
122+
Performance/IoReadlines:
123+
Enabled: true
124+
125+
Performance/MapCompact:
126+
Enabled: false
127+
128+
Performance/MapMethodChain:
129+
Enabled: false
130+
131+
Performance/MethodObjectAsBlock:
132+
Enabled: true
133+
134+
Performance/OpenStruct:
135+
Enabled: true
136+
137+
Performance/RangeInclude:
138+
Enabled: true
139+
140+
Performance/RedundantBlockCall:
141+
Enabled: false
142+
143+
Performance/RedundantEqualityComparisonBlock:
144+
Enabled: false
145+
146+
Performance/RedundantMatch:
147+
Enabled: true
148+
149+
Performance/RedundantMerge:
150+
Enabled: true
151+
MaxKeyValuePairs: 2
152+
153+
Performance/RedundantSortBlock:
154+
Enabled: true
155+
156+
Performance/RedundantSplitRegexpArgument:
157+
Enabled: true
158+
159+
Performance/RedundantStringChars:
160+
Enabled: true
161+
162+
Performance/RegexpMatch:
163+
Enabled: true
164+
165+
Performance/ReverseEach:
166+
Enabled: true
167+
168+
Performance/ReverseFirst:
169+
Enabled: true
170+
171+
Performance/SelectMap:
172+
Enabled: false
173+
174+
Performance/Size:
175+
Enabled: true
176+
177+
Performance/SortReverse:
178+
Enabled: true
179+
180+
Performance/Squeeze:
181+
Enabled: true
182+
183+
Performance/StartWith:
184+
Enabled: true
185+
186+
Performance/StringIdentifierArgument:
187+
Enabled: true
188+
189+
Performance/StringInclude:
190+
Enabled: true
191+
192+
Performance/StringReplacement:
193+
Enabled: true
194+
195+
Performance/Sum:
196+
Enabled: false
197+
198+
Performance/TimesMap:
199+
Enabled: true
200+
201+
Performance/UnfreezeString:
202+
Enabled: true
203+
204+
Performance/UriDefaultParser:
205+
Enabled: true
206+
46207
Style/HashSyntax:
47208
Enabled: true

‎Gemfile

+1
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@ end
1515

1616
group :rubocop do
1717
gem 'rubocop'
18+
gem 'rubocop-performance'
1819
end

‎Gemfile.lock

+9
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ GEM
124124
net-smtp
125125
marcel (1.0.2)
126126
mini_mime (1.1.5)
127+
mini_portile2 (2.8.5)
127128
minitest (5.20.0)
128129
minitest-reporters (1.6.1)
129130
ansi
@@ -144,6 +145,9 @@ GEM
144145
net-protocol
145146
nio4r (2.5.9)
146147
nio4r (2.5.9-java)
148+
nokogiri (1.15.4)
149+
mini_portile2 (~> 2.8.2)
150+
racc (~> 1.4)
147151
nokogiri (1.15.4-arm64-darwin)
148152
racc (~> 1.4)
149153
nokogiri (1.15.4-java)
@@ -226,6 +230,9 @@ GEM
226230
unicode-display_width (>= 2.4.0, < 3.0)
227231
rubocop-ast (1.29.0)
228232
parser (>= 3.2.1.0)
233+
rubocop-performance (1.19.1)
234+
rubocop (>= 1.7.0, < 2.0)
235+
rubocop-ast (>= 0.4.0)
229236
ruby-progressbar (1.13.0)
230237
ruby2_keywords (0.0.5)
231238
simplecov (0.22.0)
@@ -254,6 +261,7 @@ GEM
254261
PLATFORMS
255262
arm64-darwin-22
256263
java
264+
ruby
257265
x86_64-linux
258266

259267
DEPENDENCIES
@@ -264,6 +272,7 @@ DEPENDENCIES
264272
rails (~> 7.1.0)
265273
rails-controller-testing
266274
rubocop
275+
rubocop-performance
267276
simplecov
268277
simplecov-cobertura
269278

‎bin/rake

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
1515
bundle_binstub = File.expand_path("../bundle", __FILE__)
1616

1717
if File.file?(bundle_binstub)
18-
if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
18+
if File.read(bundle_binstub, 300).include?('This file was generated by Bundler')
1919
load(bundle_binstub)
2020
else
2121
abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.

‎gemfiles/rails_61/Gemfile.lock

+5
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ GEM
9595
marcel (1.0.2)
9696
method_source (1.0.0)
9797
mini_mime (1.1.5)
98+
mini_portile2 (2.8.5)
9899
minitest (5.20.0)
99100
minitest-reporters (1.6.1)
100101
ansi
@@ -114,6 +115,9 @@ GEM
114115
net-protocol
115116
nio4r (2.5.9)
116117
nio4r (2.5.9-java)
118+
nokogiri (1.15.4)
119+
mini_portile2 (~> 2.8.2)
120+
racc (~> 1.4)
117121
nokogiri (1.15.4-arm64-darwin)
118122
racc (~> 1.4)
119123
nokogiri (1.15.4-java)
@@ -194,6 +198,7 @@ GEM
194198
PLATFORMS
195199
arm64-darwin-22
196200
java
201+
ruby
197202
x86_64-linux
198203

199204
DEPENDENCIES

‎gemfiles/rails_70/Gemfile

-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,3 @@ group :development do
1212
gem 'simplecov', require: false
1313
gem 'simplecov-cobertura'
1414
end
15-
16-
group :rubocop do
17-
gem 'rubocop'
18-
end

‎gemfiles/rails_70/Gemfile.lock

+5-27
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ GEM
7676
minitest (>= 5.1)
7777
tzinfo (~> 2.0)
7878
ansi (1.5.0)
79-
ast (2.4.2)
80-
base64 (0.1.1)
8179
builder (3.2.4)
8280
concurrent-ruby (1.2.2)
8381
crass (1.0.6)
@@ -92,9 +90,6 @@ GEM
9290
activesupport (>= 5.2)
9391
i18n (1.14.1)
9492
concurrent-ruby (~> 1.0)
95-
json (2.6.3)
96-
json (2.6.3-java)
97-
language_server-protocol (3.17.0.3)
9893
loofah (2.21.4)
9994
crass (~> 1.0.2)
10095
nokogiri (>= 1.12.0)
@@ -106,6 +101,7 @@ GEM
106101
marcel (1.0.2)
107102
method_source (1.0.0)
108103
mini_mime (1.1.5)
104+
mini_portile2 (2.8.5)
109105
minitest (5.20.0)
110106
minitest-reporters (1.6.1)
111107
ansi
@@ -125,16 +121,15 @@ GEM
125121
net-protocol
126122
nio4r (2.5.9)
127123
nio4r (2.5.9-java)
124+
nokogiri (1.15.4)
125+
mini_portile2 (~> 2.8.2)
126+
racc (~> 1.4)
128127
nokogiri (1.15.4-arm64-darwin)
129128
racc (~> 1.4)
130129
nokogiri (1.15.4-java)
131130
racc (~> 1.4)
132131
nokogiri (1.15.4-x86_64-linux)
133132
racc (~> 1.4)
134-
parallel (1.23.0)
135-
parser (3.2.2.4)
136-
ast (~> 2.4.1)
137-
racc
138133
racc (1.7.1)
139134
racc (1.7.1-java)
140135
rack (2.2.8)
@@ -172,27 +167,11 @@ GEM
172167
rake (>= 12.2)
173168
thor (~> 1.0)
174169
zeitwerk (~> 2.5)
175-
rainbow (3.1.1)
176170
rake (13.0.6)
177-
regexp_parser (2.8.2)
178171
responders (3.1.1)
179172
actionpack (>= 5.2)
180173
railties (>= 5.2)
181174
rexml (3.2.6)
182-
rubocop (1.57.1)
183-
base64 (~> 0.1.1)
184-
json (~> 2.3)
185-
language_server-protocol (>= 3.17.0)
186-
parallel (~> 1.10)
187-
parser (>= 3.2.2.4)
188-
rainbow (>= 2.2.2, < 4.0)
189-
regexp_parser (>= 1.8, < 3.0)
190-
rexml (>= 3.2.5, < 4.0)
191-
rubocop-ast (>= 1.28.1, < 2.0)
192-
ruby-progressbar (~> 1.7)
193-
unicode-display_width (>= 2.4.0, < 3.0)
194-
rubocop-ast (1.29.0)
195-
parser (>= 3.2.1.0)
196175
ruby-progressbar (1.13.0)
197176
ruby2_keywords (0.0.5)
198177
simplecov (0.22.0)
@@ -208,7 +187,6 @@ GEM
208187
timeout (0.4.0)
209188
tzinfo (2.0.6)
210189
concurrent-ruby (~> 1.0)
211-
unicode-display_width (2.5.0)
212190
websocket-driver (0.7.6)
213191
websocket-extensions (>= 0.1.0)
214192
websocket-driver (0.7.6-java)
@@ -219,6 +197,7 @@ GEM
219197
PLATFORMS
220198
arm64-darwin-22
221199
java
200+
ruby
222201
x86_64-linux
223202

224203
DEPENDENCIES
@@ -228,7 +207,6 @@ DEPENDENCIES
228207
mocha
229208
rails (~> 7.0.0)
230209
rails-controller-testing
231-
rubocop
232210
simplecov
233211
simplecov-cobertura
234212

‎lib/inherited_resources/blank_slate.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module InheritedResources
44
# An object from BlankSlate simply discards all messages sent to it.
55
class BlankSlate
66
instance_methods.each do |m|
7-
undef_method m unless m =~ /^(__|object_id)/
7+
undef_method m unless /^(__|object_id)/.match?(m)
88
end
99

1010
def method_missing(*args)

0 commit comments

Comments
 (0)