Skip to content

Commit 0170547

Browse files
authored
adding test for undici issue 971 (#611)
* adding test for nodejs/undici#2971 * lint
1 parent 59e7074 commit 0170547

File tree

2 files changed

+22
-17
lines changed

2 files changed

+22
-17
lines changed

Diff for: tests/basic_tests.cpp

+14
Original file line numberDiff line numberDiff line change
@@ -417,3 +417,17 @@ TYPED_TEST(basic_tests, nodejs_51619) {
417417
ASSERT_FALSE(out);
418418
SUCCEED();
419419
}
420+
421+
// https://github.com/nodejs/undici/pull/2971
422+
TYPED_TEST(basic_tests, nodejs_undici_2971) {
423+
std::string_view base =
424+
"https://non-ascii-location-header.sys.workers.dev/redirect";
425+
auto base_url = ada::parse<TypeParam>(base);
426+
ASSERT_TRUE(base_url);
427+
auto out = ada::parse<TypeParam>("/\xec\x95\x88\xeb\x85\x95", &*base_url);
428+
ASSERT_TRUE(out);
429+
ASSERT_EQ(
430+
out->get_href(),
431+
R"(https://non-ascii-location-header.sys.workers.dev/%EC%95%88%EB%85%95)");
432+
SUCCEED();
433+
}

Diff for: tools/run-clangcldocker.sh

+8-17
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,22 @@
11
#!/usr/bin/env bash
22
set -e
3-
SCRIPT_PATH="$( cd "$(dirname "$0")" ; pwd -P )"
4-
ROOT_PATH=$SCRIPT_PATH/..
5-
ALL_ADA_FILES=$(cd "$ROOT_PATH" && git ls-tree --full-tree --name-only -r HEAD | grep -e ".*\.\(c\|h\|cc\|cpp\|hh\)\$" | grep -vFf clang-format-ignore.txt)
3+
COMMAND=$*
4+
SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )"
5+
MAINSOURCE=$SCRIPTPATH/..
6+
ALL_ADA_FILES=$(cd $MAINSOURCE && git ls-tree --full-tree --name-only -r HEAD | grep -e ".*\.\(c\|h\|cc\|cpp\|hh\)\$" | grep -vFf clang-format-ignore.txt)
67

78
if clang-format-15 --version 2>/dev/null | grep -qF 'version 15.'; then
8-
cd "$ROOT_PATH"; clang-format-15 --style=file --verbose -i "$@" "$ALL_ADA_FILES"
9+
cd $MAINSOURCE; clang-format-15 --style=file --verbose -i "$@" $ALL_ADA_FILES
910
exit 0
1011
elif clang-format --version 2>/dev/null | grep -qF 'version 15.'; then
11-
cd "$ROOT_PATH"; clang-format --style=file --verbose -i "$@" "$ALL_ADA_FILES"
12+
cd $MAINSOURCE; clang-format --style=file --verbose -i "$@" $ALL_ADA_FILES
1213
exit 0
1314
fi
1415
echo "Trying to use docker"
1516
command -v docker >/dev/null 2>&1 || { echo >&2 "Please install docker. E.g., go to https://www.docker.com/products/docker-desktop Type 'docker' to diagnose the problem."; exit 1; }
1617
docker info >/dev/null 2>&1 || { echo >&2 "Docker server is not running? type 'docker info'."; exit 1; }
1718

18-
if [ -t 0 ];
19-
then DOCKER_ARGS=-it;
20-
fi
21-
19+
if [ -t 0 ]; then DOCKER_ARGS=-it; fi
2220
docker pull kszonek/clang-format-15
2321

24-
docker run --rm $DOCKER_ARGS \
25-
-v "$ROOT_PATH":"$ROOT_PATH":Z \
26-
-w "$ROOT_PATH" \
27-
-u "$(id -u "$USER"):$(id -g "$USER")" \
28-
kszonek/clang-format-15 \
29-
--style=file \
30-
--verbose \
31-
-i "$@" "$ALL_ADA_FILES"
22+
docker run --rm $DOCKER_ARGS -v "$MAINSOURCE":"$MAINSOURCE":Z -w "$MAINSOURCE" -u "$(id -u $USER):$(id -g $USER)" kszonek/clang-format-15 --style=file --verbose -i "$@" $ALL_ADA_FILES

0 commit comments

Comments
 (0)