Skip to content

Commit 5a30fed

Browse files
committed
1 parent 2d00fa2 commit 5a30fed

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

chromium/extension/popup/controller.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,8 @@
168168
document.querySelectorAll('[data-locale-text-content], [data-locale-title]').forEach(elemToLocalize =>
169169
Object.entries(elemToLocalize.dataset).forEach(([dataAttr, dataVal]) => {
170170
if (!dataAttr.startsWith('locale')) return
171-
const propToLocalize = dataAttr // convert to valid DOM prop e.g. localeTextContent => textContent
172-
.replace(/^locale/, '')[0].toLowerCase() + dataAttr.slice(7)
173-
const localizedTxt = dataVal.split(' ').map(key => getMsg(key) || key).join(' ')
171+
const propToLocalize = dataAttr[6].toLowerCase() + dataAttr.slice(7), // convert to valid DOM prop
172+
localizedTxt = dataVal.split(' ').map(key => getMsg(key) || key).join(' ')
174173
elemToLocalize[propToLocalize] = localizedTxt
175174
})
176175
)

firefox/extension/popup/controller.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,8 @@
170170
document.querySelectorAll('[data-locale-text-content], [data-locale-title]').forEach(elemToLocalize =>
171171
Object.entries(elemToLocalize.dataset).forEach(([dataAttr, dataVal]) => {
172172
if (!dataAttr.startsWith('locale')) return
173-
const propToLocalize = dataAttr // convert to valid DOM prop e.g. localeTextContent => textContent
174-
.replace(/^locale/, '')[0].toLowerCase() + dataAttr.slice(7)
175-
const localizedTxt = dataVal.split(' ').map(key => getMsg(key) || key).join(' ')
173+
const propToLocalize = dataAttr[6].toLowerCase() + dataAttr.slice(7), // convert to valid DOM prop
174+
localizedTxt = dataVal.split(' ').map(key => getMsg(key) || key).join(' ')
176175
elemToLocalize[propToLocalize] = localizedTxt
177176
})
178177
)

0 commit comments

Comments
 (0)