Skip to content

Commit db9c770

Browse files
qili26amanmahajan7
qili26
authored andcommitted
fix: draggable resizing col jumps to right (#1421)
* fix: draggable resizing col jumps to right * refactor: use ref instead of findDOMNode * fix: accidentally removed cel
1 parent 4c48024 commit db9c770

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

packages/react-data-grid/src/HeaderCell.js

+8-5
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ class HeaderCell extends React.Component {
3333

3434
state = {resizing: false};
3535

36+
headerCellRef = (node) => this.headerCell = node;
37+
3638
onDragStart = (e) => {
3739
this.setState({resizing: true});
3840
// need to set dummy data for FF
@@ -56,8 +58,8 @@ class HeaderCell extends React.Component {
5658
};
5759

5860
getWidthFromMouseEvent = (e) => {
59-
let right = e.pageX || (e.touches && e.touches[0] && e.touches[0].pageX) || (e.changedTouches && e.changedTouches[e.changedTouches.length - 1].pageX);
60-
let left = ReactDOM.findDOMNode(this).getBoundingClientRect().left;
61+
const right = e.pageX || (e.touches && e.touches[0] && e.touches[0].pageX) || (e.changedTouches && e.changedTouches[e.changedTouches.length - 1].pageX);
62+
const left = this.headerCell ? this.headerCell.getBoundingClientRect().left : 0;
6163
return right - left;
6264
};
6365

@@ -118,7 +120,7 @@ class HeaderCell extends React.Component {
118120
'react-grid-HeaderCell--frozen': columnUtils.isFrozen(column)
119121
}, this.props.className, column.cellClass);
120122
const cell = (
121-
<div className={className} style={this.getStyle()}>
123+
<div ref={this.headerCellRef} className={className} style={this.getStyle()}>
122124
{this.getCell()}
123125
{resizeHandle}
124126
</div>
@@ -129,8 +131,9 @@ class HeaderCell extends React.Component {
129131
return (
130132
<DraggableHeaderCell
131133
column={column}
132-
onHeaderDrop={this.props.onHeaderDrop}>
133-
{cell}
134+
onHeaderDrop={this.props.onHeaderDrop}
135+
>
136+
{cell}
134137
</DraggableHeaderCell>
135138
);
136139
}

0 commit comments

Comments
 (0)