Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Size jumping when using hooks #1581

Closed
3 of 11 tasks
LBWright opened this issue Apr 12, 2019 · 4 comments
Closed
3 of 11 tasks

Header Size jumping when using hooks #1581

LBWright opened this issue Apr 12, 2019 · 4 comments

Comments

@LBWright
Copy link

  • Have you already searched for similar issues? Please help us out and double-check first!

  • Also, please don't be that person who deletes this template. It's here for a reason.

  • Thanks!


Which version of React JS are you using?

✅ Officially supported ✅

  • v15.4.x

⚠️ Not officially supported, expect warnings ⚠️

  • v15.5.x
  • v15.6.x

☣️ Not officially supported, expect warnings and errors ☣️

  • v16.8.x

Which browser are you using?

✅ Officially supported ✅

  • IE 9 / IE 10 / IE 11
  • Edge
  • Chrome

⚠️ Not officially supported, but "should work" ⚠️

  • Firefox
  • Safari

I'm submitting a ...

  • 🐛 Bug Report
  • 💡 Feature Request

👋 Need general support? Not sure about how to use React itself, or how to get started with the Grid?
Please do not submit support request here. Instead see

https://github.com/adazzle/react-data-grid/blob/master/CONTRIBUTING.md


Issue Details

Please include:
- What the current behavior is
  When resizing columns when DraggableContainer parent component wraps the React Data Grid, the size of the header jumps 20-70px, on click.
- What the desired behvaior is
  The header should not resize until the user moves the mouse.
- (If Bug) Steps to reproduce the issue
  Wrap the ReactDataGrid with the DraggableContainer, and use React hooks to update the columns.
- (If Feature) The motivation / use case for the feature

We especially love screenshots / videos of problems, and remember
The Best Issue Is A Pull Request™

It's hard to get a screenshot of the issue. It's completely possible that it's our implementation, but going through the values inside of the VSCode debugger, we notice that the size of the window immediately changes inside of the react-data-grid functions themselves.

@ggcatu
Copy link

ggcatu commented Apr 23, 2019

I think this is related to #1421
Are you experiencing this on 6.x ?
#1564

@LBWright
Copy link
Author

Yes. The version I'm experiencing this on is 6.1.0-0.

@LBWright
Copy link
Author

@ggcatu This is exactly it. Thanks!

@amanmahajan7
Copy link
Contributor

We have re-implemented header resize in v7 canary. Can you give it a try and open a new issue if it still exists?
https://adazzle.github.io/react-data-grid/canary/?path=/story/demos--common-features
https://github.com/adazzle/react-data-grid/tree/canary/stories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants