Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XPath expression in subtree #289

Open
adbar opened this issue Jan 19, 2023 · 1 comment
Open

Fix XPath expression in subtree #289

adbar opened this issue Jan 19, 2023 · 1 comment
Labels
maintenance Software compability and continuity

Comments

@adbar
Copy link
Owner

adbar commented Jan 19, 2023 •
edited
Loading

In core.py the XPath expression is unnecessarily wide:

ptest = subtree.xpath(//p//text())

In this part, it is marked as //p//text() so It's looking for the root's p-tag rather than the subtree's p-tag.

.//p//text() would be the right approach.

Originally posted by @jake-yi in #287
@adbar
Copy link
Owner Author

adbar commented Jan 19, 2023

It changes the extraction parameters so the thresholds below have to be revised.

@adbar adbar added the bug Something isn't working label Jan 19, 2023
@adbar adbar added maintenance Software compability and continuity and removed bug Something isn't working labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Software compability and continuity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adbar