feat: make http config deep partial

Author: thetutlage

src/define_config.ts

@@ -10,8 +10,15 @@
 import proxyAddr from 'proxy-addr'
 import string from '@poppinss/utils/string'
 import type { ServerConfig } from './types/server.js'
+import lodash from '@poppinss/utils/lodash'
 
-type UserDefinedServerConfig = Partial<
+type DeepPartial<T> = T extends object
+  ? {
+      [P in keyof T]?: DeepPartial<T[P]>
+    }
+  : T
+
+type UserDefinedServerConfig = DeepPartial<
   Omit<ServerConfig, 'trustProxy'> & {
     trustProxy: ((address: string, distance: number) => boolean) | boolean | string
   }
@@ -23,7 +30,7 @@ type UserDefinedServerConfig = Partial<
 export function defineConfig(config: UserDefinedServerConfig): ServerConfig {
   const { trustProxy, ...rest } = config
 
-  const normalizedConfig = {
+  const defaults = {
     allowMethodSpoofing: false,
     trustProxy: proxyAddr.compile('loopback'),
     subdomainOffset: 2,
@@ -53,8 +60,9 @@ export function defineConfig(config: UserDefinedServerConfig): ServerConfig {
         skipNulls: false,
       },
     },
-    ...rest,
-  }
+  } satisfies ServerConfig
+
+  const normalizedConfig: ServerConfig = lodash.merge({}, defaults, rest)
 
   /**
    * Normalizing maxAge property on cookies to be a number in

tests/define_config.spec.ts

@@ -54,7 +54,7 @@ test.group('Define config', () => {
     assert.typeOf(config.trustProxy, 'function')
   })
 
-  test('comfile trustProxy config when string', ({ assert }) => {
+  test('compile trustProxy config when string', ({ assert }) => {
     const config = defineConfig({ trustProxy: 'loopback' })
 
     assert.typeOf(config.trustProxy, 'function')
@@ -65,4 +65,40 @@ test.group('Define config', () => {
     const config = defineConfig({ trustProxy: fn })
     assert.strictEqual(config.trustProxy, fn)
   })
+
+  test('deep merge user values with defaults', ({ assert }) => {
+    const config = defineConfig({
+      cookie: {
+        httpOnly: false,
+      },
+      qs: {
+        parse: {
+          comma: false,
+        },
+      },
+    })
+
+    assert.deepEqual(config.cookie, {
+      httpOnly: false,
+      path: '/',
+      maxAge: 7200,
+      sameSite: 'lax',
+      secure: true,
+    })
+    assert.deepEqual(config.qs, {
+      parse: {
+        depth: 5,
+        parameterLimit: 1000,
+        allowSparse: false,
+        arrayLimit: 20,
+        comma: false,
+      },
+      stringify: {
+        encode: true,
+        encodeValuesOnly: false,
+        arrayFormat: 'indices' as const,
+        skipNulls: false,
+      },
+    })
+  })
 })