Skip to content

Commit d1cae72

Browse files
fix things as per Matthew's review - though this remains a breaking change.
1 parent e1e7c57 commit d1cae72

File tree

4 files changed

+8
-22
lines changed

4 files changed

+8
-22
lines changed

CHANGELOG.md

-7
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,6 @@ Additions to existing modules
180180
rawModule : RawModule R c ℓ
181181
```
182182

183-
* In `Algebra.Morphism.Structures`:
184-
```agda
185-
IsSemigroupHomomorphism : (A → B) → Set _
186-
IsSemigroupMonomorphism : (A → B) → Set _
187-
IsSemigroupIsomorphism : (A → B) → Set _
188-
```
189-
190183
* In `Algebra.Properties.Group`:
191184
```agda
192185
isQuasigroup : IsQuasigroup _∙_ _\\_ _//_

src/Algebra/Morphism/Structures.agda

-9
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,6 @@ module MagmaMorphisms (M₁ : RawMagma a ℓ₁) (M₂ : RawMagma b ℓ₂) wher
6868
; surjective = surjective
6969
}
7070

71-
IsSemigroupHomomorphism : (⟦_⟧ : A B) Set (a ⊔ ℓ₁ ⊔ ℓ₂)
72-
IsSemigroupHomomorphism = IsMagmaHomomorphism
73-
74-
IsSemigroupMonomorphism : (⟦_⟧ : A B) Set (a ⊔ ℓ₁ ⊔ ℓ₂)
75-
IsSemigroupMonomorphism = IsMagmaMonomorphism
76-
77-
IsSemigroupIsomorphism : (⟦_⟧ : A B) Set (a ⊔ b ⊔ ℓ₁ ⊔ ℓ₂)
78-
IsSemigroupIsomorphism = IsMagmaIsomorphism
79-
8071
------------------------------------------------------------------------
8172
-- Morphisms over monoid-like structures
8273
------------------------------------------------------------------------

src/Function/Endomorphism/Propositional.agda

+6-4
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77
{-# OPTIONS --cubical-compatible --safe #-}
88
module Function.Endomorphism.Propositional {a} (A : Set a) where
99

10-
open import Algebra
11-
open import Algebra.Structures
10+
open import Algebra using (Semigroup; Magma; RawMagma; Monoid; RawMonoid)
11+
open import Algebra.Core
12+
open import Algebra.Structures using (IsMagma; IsSemigroup; IsMonoid)
1213
open import Algebra.Morphism
13-
open Definitions
14+
using (module Definitions; IsMagmaHomomorphism; IsMonoidHomomorphism)
15+
open Definitions using (Homomorphic₂)
1416

1517
open import Data.Nat.Base using (ℕ; _+_; zero; suc; +-rawMagma; +-0-rawMonoid)
1618
open import Data.Nat.Properties using (+-0-monoid; +-semigroup)
@@ -92,7 +94,7 @@ private
9294
------------------------------------------------------------------------
9395
-- Homomorphism
9496

95-
^-isSemigroupMorphism : f IsSemigroupHomomorphism +-rawMagma ∘-rawMagma (f ^_)
97+
^-isSemigroupMorphism : f IsMagmaHomomorphism +-rawMagma ∘-rawMagma (f ^_)
9698
^-isSemigroupMorphism f = record
9799
{ isRelHomomorphism = record { cong = cong (f ^_) }
98100
; homo = ^-homo f

src/Function/Endomorphism/Setoid.agda

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ open import Agda.Builtin.Equality
1515
open import Algebra using (Semigroup; Magma; RawMagma; Monoid; RawMonoid)
1616
open import Algebra.Structures using (IsMagma; IsSemigroup; IsMonoid)
1717
open import Algebra.Morphism
18-
using (module Definitions; IsSemigroupHomomorphism; IsMonoidHomomorphism)
18+
using (module Definitions; IsMagmaHomomorphism; IsMonoidHomomorphism)
1919
open Definitions using (Homomorphic₂)
2020
open import Data.Nat.Base using (ℕ; _+_; +-rawMagma; +-0-rawMonoid)
2121
open
@@ -98,7 +98,7 @@ private
9898
------------------------------------------------------------------------
9999
-- Homomorphism
100100

101-
^-isSemigroupHomomorphism : f IsSemigroupHomomorphism +-rawMagma ∘-rawMagma (f ^_)
101+
^-isSemigroupHomomorphism : f IsMagmaHomomorphism +-rawMagma ∘-rawMagma (f ^_)
102102
^-isSemigroupHomomorphism f = record
103103
{ isRelHomomorphism = record { cong = ^-cong₂ f }
104104
; homo = ^-homo f

0 commit comments

Comments
 (0)