Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernising Data.Nat.Properties #2088

Closed
3 tasks
jamesmckinna opened this issue Sep 13, 2023 · 3 comments · Fixed by #2089
Closed
3 tasks

Modernising Data.Nat.Properties #2088

jamesmckinna opened this issue Sep 13, 2023 · 3 comments · Fixed by #2089
Milestone

Comments

@jamesmckinna
Copy link
Contributor

jamesmckinna commented Sep 13, 2023

Two quick thoughts, plus a placeholder:

  • currently, there is no use of variables !
  • suc-injective can be made lazier by redefining it as cong pred, and systematically replacing uses of that compound elsewhere?
  • anything else?

NB this is intended to be cosmetic for v2.0, not the systematic overhaul envisaged by @JacquesCarette in #1925

Note to self: could be folded into any PR addressing #2087

@jamesmckinna
Copy link
Contributor Author

I'm sure that this sort of issue will recur, but closing this now (and should have, after #2089).

@MatthewDaggitt
Copy link
Contributor

@jamesmckinna when you close issues because a PR has addressed them, can you check that there's the correct Milestone added and the PR is linked against in the Development box (both on the RHS). Makes it a little easier to sort and filter historical issues when doing archaeology!

@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Dec 13, 2023

Certainly! Sorry to have missed your comment until now.

@jamesmckinna jamesmckinna reopened this Dec 13, 2023
@jamesmckinna jamesmckinna added this to the v2.0 milestone Dec 13, 2023
@jamesmckinna jamesmckinna linked a pull request Dec 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants