Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some properties of unnormalised rationals are named inconsistently #2550

Closed
SlimTim10 opened this issue Jan 15, 2025 · 1 comment
Closed
Labels
status: duplicate The main contents of the issue or PR already exists in another issue or PR.
Milestone

Comments

@SlimTim10
Copy link

SlimTim10 commented Jan 15, 2025

Compare

*-monoˡ-≤-nonNeg : r .{{_ : NonNegative r}} (_* r) Preserves _≤_ ⟶ _≤_

to

*-monoˡ-≤-nonNeg : r .{{_ : NonNegative r}} (r *_) Preserves _≤_ ⟶ _≤_

*-monoˡ-≤-nonNeg should be swapped with *-monoʳ-≤-nonNeg. Same for a few others nearby.

@jamesmckinna
Copy link
Contributor

This is a duplicate of the still-open #1579 ... cf. #1436 and related PRs... still a mess I'm afraid after all these years, and because fixing it would be a non-trivial breaking change, it's only going to be tackled in v3.0... :-(

@jamesmckinna jamesmckinna added the status: duplicate The main contents of the issue or PR already exists in another issue or PR. label Jan 15, 2025
@jamesmckinna jamesmckinna added this to the v3.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate The main contents of the issue or PR already exists in another issue or PR.
Projects
None yet
Development

No branches or pull requests

2 participants