Skip to content

Forward slashes are not allowed in broker virtual host in profile setup #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sphuber opened this issue Sep 26, 2020 · 0 comments · Fixed by #4408
Closed

Forward slashes are not allowed in broker virtual host in profile setup #4403

sphuber opened this issue Sep 26, 2020 · 0 comments · Fixed by #4408

Comments

@sphuber
Copy link
Contributor

sphuber commented Sep 26, 2020

The new broker configuration parameters that have been added in v1.4.0 have an optional broker virtual host field. Currently, names containing a forward slash fail validation, because the validator is based on a hostname validator, which cannot contain forward slashes. However, virtual hosts typically start with a forward slash, so users may be tempted to pass it but will be presented with a validation error. The help string message is misleading because it says that forward slashes need to be encoded.

The code that forms the URL based on the broker configuration of the profile will take care of adding a leading forward slash in case of a virtual host and it will encode the entire path. So at the very least, we should adapt the help string to say that the leading slash is not necessary and remove the comment about encoding. Ideally, any leading slashes are stripped before passing it to the validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant