Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Commit 41bbf62

Browse files
authored
fix(presto): use correct timespec for presto (apache#20333)
1 parent 998624b commit 41bbf62

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

superset/db_engine_specs/presto.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,7 @@ def convert_dttm(
761761
utils.TemporalType.TIMESTAMP,
762762
utils.TemporalType.TIMESTAMP_WITH_TIME_ZONE,
763763
):
764-
return f"""TIMESTAMP '{dttm.isoformat(timespec="microseconds", sep=" ")}'"""
764+
return f"""TIMESTAMP '{dttm.isoformat(timespec="milliseconds", sep=" ")}'"""
765765
return None
766766

767767
@classmethod

tests/unit_tests/db_engine_specs/test_presto.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,17 @@
3030
(
3131
"TIMESTAMP",
3232
datetime(2022, 1, 1, 1, 23, 45, 600000),
33-
"TIMESTAMP '2022-01-01 01:23:45.600000'",
33+
"TIMESTAMP '2022-01-01 01:23:45.600'",
3434
),
3535
(
3636
"TIMESTAMP WITH TIME ZONE",
3737
datetime(2022, 1, 1, 1, 23, 45, 600000),
38-
"TIMESTAMP '2022-01-01 01:23:45.600000'",
38+
"TIMESTAMP '2022-01-01 01:23:45.600'",
3939
),
4040
(
4141
"TIMESTAMP WITH TIME ZONE",
4242
datetime(2022, 1, 1, 1, 23, 45, 600000, tzinfo=pytz.UTC),
43-
"TIMESTAMP '2022-01-01 01:23:45.600000+00:00'",
43+
"TIMESTAMP '2022-01-01 01:23:45.600+00:00'",
4444
),
4545
],
4646
)

0 commit comments

Comments
 (0)