Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: alexa/ask-toolkit-for-vscode
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.11.3
Choose a base ref
...
head repository: alexa/ask-toolkit-for-vscode
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.11.4
Choose a head ref
  • 15 commits
  • 10 files changed
  • 5 contributors

Commits on Jul 18, 2022

  1. Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    76921c0 View commit details
  2. Merge pull request #194 from alexa/development-stale

    chore: changing stale bot to 60 day stale time (from 14)
    tydonelson authored Jul 18, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2394448 View commit details

Commits on Jul 25, 2022

  1. Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    d689434 View commit details
  2. Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    f97bf3f View commit details
  3. chore: import formatting

    tydonelson committed Jul 25, 2022

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    e2cbe74 View commit details

Commits on Jul 26, 2022

  1. Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    b996b18 View commit details
  2. Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    7396d89 View commit details
  3. Merge pull request #196 from alexa/development-profile-delete

    fix: make profile deletion error more helpful
    tydonelson authored Jul 26, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c73061d View commit details
  4. chore: bump terser from 5.7.1 to 5.14.2

    Bumps [terser](https://github.com/terser/terser) from 5.7.1 to 5.14.2.
    - [Release notes](https://github.com/terser/terser/releases)
    - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/terser/terser/commits)
    
    ---
    updated-dependencies:
    - dependency-name: terser
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Jul 26, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    0089fe2 View commit details

Commits on Jul 27, 2022

  1. Merge pull request #164 from ajsb85/development

    Use localhost instead 127.0.0.1 for WSL support
    doiron authored and tydonelson committed Jul 27, 2022

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    b4407be View commit details

Commits on Aug 1, 2022

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    98b6594 View commit details
  2. Merge pull request #197 from alexa/development-localhost

    fix: use localhost instead of 127.0.0.1 for LWA redirect
    tydonelson authored Aug 1, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    35afe03 View commit details

Commits on Aug 10, 2022

  1. Merge pull request #200 from alexa/development-FAQ

    chore: add section in FAQ for access token error+workaround
    tydonelson authored Aug 10, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    da33489 View commit details

Commits on Aug 30, 2022

  1. Merge pull request #195 from alexa/dependabot/npm_and_yarn/terser-5.14.2

    chore: bump terser from 5.7.1 to 5.14.2
    doiron authored Aug 30, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    eba67f4 View commit details

Commits on Aug 31, 2022

  1. chore(release): 2.11.4

    ask-sdk committed Aug 31, 2022

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    3c56d0f View commit details
Showing with 11,132 additions and 10,932 deletions.
  1. +3 −3 .github/workflows/stale.yml
  2. +2 −1 .prettierrc
  3. +7 −0 CHANGELOG.md
  4. +25 −0 README.md
  5. +10,666 −10,538 package-lock.json
  6. +389 −387 package.json
  7. +2 −1 src/askContainer/webViews/profileManagerWebview.ts
  8. +1 −1 src/runtime/lib/utils/lwa.ts
  9. +1 −1 src/utils/captchaValidator.ts
  10. +36 −0 test/askContainer/webview/profileManagerWebview.test.ts
6 changes: 3 additions & 3 deletions .github/workflows/stale.yml
Original file line number Diff line number Diff line change
@@ -11,10 +11,10 @@ jobs:
- uses: actions/stale@v3
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: "This issue is stale since it has been open for 14 days with no activity. Please respond or this issue will be closed soon."
stale-issue-message: "This issue is stale since it has been open for 60 days with no activity. Please respond or this issue will be closed soon."
close-issue-message: "This stale issue has been closed now. Please reopen the issue if you are still having problems with the toolkit."
stale-pr-message: "This pr is stale since it has been open for 14 days with no activity. Please respond or this pr will be closed soon."
stale-pr-message: "This pr is stale since it has been open for 60 days with no activity. Please respond or this pr will be closed soon."
stale-issue-label: "closing soon if no response"
stale-pr-label: "no-pr-activity"
exempt-issue-labels: "feature-request,waiting: external dependency,investigating,in progress,enhancement"
days-before-stale: 14
days-before-stale: 60
3 changes: 2 additions & 1 deletion .prettierrc
Original file line number Diff line number Diff line change
@@ -8,5 +8,6 @@
"singleQuote": false,
"tabWidth": 2,
"trailingComma": "all",
"useTabs": false
"useTabs": false,
"endOfLine": "auto"
}
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [2.11.4](https://github.com/alexa/ask-toolkit-for-vscode/compare/v2.11.3...v2.11.4) (2022-08-31)


### Bug Fixes

* make profile deletion error more helpful ([d689434](https://github.com/alexa/ask-toolkit-for-vscode/commits/d689434b76c16574c5f1b6cd2f15fb1f95d61aa0))

### [2.11.3](https://github.com/alexa/ask-toolkit-for-vscode/compare/v2.11.2...v2.11.3) (2022-07-15)


25 changes: 25 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -196,6 +196,31 @@ and many more ...
- **The latest version seems to be not installable on my vscode. What is the minimum compatible vscode version for the toolkit?**
- ASK Toolkit (`v2.5.0` and above) works with <a href=" https://code.visualstudio.com/">Visual Studio Code IDE</a> (version 1.53.0 or higher), please make sure you have the latest version installed.
- **Why am I getting the error '[token] is not recognized as an internal or external command, operable program or batch file' when trying to start the local debugger?**
- For Windows users, this is sometimes caused by an incompatibility between the Debug Terminal and the way VSCode parses the launch.json configurations. A simple workaround for this is to add `"console": "integratedTerminal"` to the debug configuration in your `launch.json` file, like the following:
```
"version": "0.2.0",
"configurations": [
{
"name": "Debug Alexa Skill (Node.js)",
"type": "node",
"request": "launch",
"program": "${command:ask.debugAdapterPath}",
"args": [
"--accessToken",
"${command:ask.accessToken}",
"--skillId",
"${command:ask.skillIdFromWorkspace}",
"--handlerName",
"handler",
"--skillEntryFile",
"${workspaceFolder}/lambda/index.js",
"--region",
"FE"
],
"console": "integratedTerminal" //Add this
},
```
----
Loading