Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade APL 1.5 to 1.6 with APL Web Viewhost and APL Suggester. #122

Merged
merged 3 commits into from
May 17, 2021
Merged

Upgrade APL 1.5 to 1.6 with APL Web Viewhost and APL Suggester. #122

merged 3 commits into from
May 17, 2021

Conversation

VennSun
Copy link
Contributor

@VennSun VennSun commented Apr 30, 2021

Description

Upgrade the version from 1.5 to 1.6 with APL suggester
Upgrade the version from 1.5 to 1.6 hotfix with APL WebViewhost
Add more sample templates' mapping to vs code filter.
npm install locally and include the new package lock json.

Motivation and Context

Upgrade APL version to the latest version.

Testing

NPM build tests
Manual E2E tests with sample APL skill. Details can be found in the internal Quip Doc.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ X ] My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • [ X ] I have read the README document
  • I have added tests to cover my changes
  • [ X ] All new and existing tests passed
  • [ X ] My commit message follows Conventional Commit Guideline

License

  • [ X ] By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nikhilym
Copy link
Contributor

Hey @VennSun , thanks for the PR. Looks like the extension tests are failing. Can you please review and update the necessary dependencies, to get them running so that we are fine with the extension building on different platforms? Thanks.

@nikhilym nikhilym added the response needed use this if you need more information regarding the issue label May 10, 2021
@VennSun
Copy link
Contributor Author

VennSun commented May 13, 2021

Hey @VennSun , thanks for the PR. Looks like the extension tests are failing. Can you please review and update the necessary dependencies, to get them running so that we are fine with the extension building on different platforms? Thanks.

Hi, I have updated the Web Viewhost dependency and let's see is this version can pass all the builds on different platform. If it works, I will need to change this to an official version.

@VennSun
Copy link
Contributor Author

VennSun commented May 13, 2021

I have verified with 1.6.3-rc.1 for builds on different platform. Sent out the latest commit with official version of 1.6.3 and builds are passing as well. Please review and merge this PR. Thanks.

@nikhilym nikhilym merged commit e350c52 into alexa:development May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
response needed use this if you need more information regarding the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants