fix: updated tsconfig and also removed eslint,tslint and added prettier config #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shreyas-vgr
changed the title
ShenChen93
reviewed
Sep 30, 2021
Comment on lines
-391
to
-400
| "prettier": { | ||
| "semi": true, | ||
| "tabWidth": 4, | ||
| "printWidth": 120, | ||
| "trailingComma": "es5", | ||
| "bracketSpacing": true, | ||
| "arrowParens": "avoid", | ||
| "endOfLine": "lf", | ||
| "singleQuote": true | ||
| }, |
There was a problem hiding this comment.
Why we remove those prettier config ? Are they moved to somewhere else ?
There was a problem hiding this comment.
Yes correct, moved it to .prettierrc file
ShenChen93
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I will send out another PR running the prettier format script once this gets merged.
Testing
Types of changes
Checklist
License