Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render apl response without speak tag in simulator. fixes #82 #92

Merged
merged 1 commit into from
Feb 4, 2021
Merged

fix: render apl response without speak tag in simulator. fixes #82 #92

merged 1 commit into from
Feb 4, 2021

Conversation

nikhilym
Copy link
Contributor

@nikhilym nikhilym commented Feb 4, 2021

Description of changes:

This PR fixes the issue of not rendering APL responses, in case there is an empty speak tag in Alexa response, but valid APL response. This fixes the issue mentioned in #82

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nikhilym nikhilym added the bug Something isn't working label Feb 4, 2021
Copy link
Contributor

@wyajunjun wyajunjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great change! Tested it, good to know that in the skill, the alexaResponse can be empty but with APL directive.

@nikhilym nikhilym merged commit e9190e0 into alexa:development Feb 4, 2021
@nikhilym nikhilym deleted the simulator_apl_fix branch February 4, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants