catch all relevant errors from trys and log

Author: alexrozanski

Diff for: LlamaChat/model/chat/MessagesModel.swift

@@ -14,7 +14,14 @@ class MessagesModel: ObservableObject {
   }()
 
   private lazy var db: Connection? = {
-    return databaseURL.flatMap { try? Connection($0.path) }
+    return databaseURL.flatMap {
+      do {
+        return try Connection($0.path)
+      } catch {
+        print("Error getting DB connection:", error)
+        return nil
+      }
+    }
   }()
 
   private let chatSourcesTable = Table("chat_sources")

Diff for: LlamaChat/model/sources/ChatSources.swift

@@ -119,7 +119,10 @@ class ChatSources: ObservableObject {
   }
 
   private func loadSources() {
-    guard let persistedURL else { return }
+    guard
+      let persistedURL,
+      FileManager.default.fileExists(atPath: persistedURL.path)
+    else { return }
 
     do {
       let jsonData = try Data(contentsOf: persistedURL)
@@ -138,7 +141,11 @@ class ChatSources: ObservableObject {
     guard let persistedURL else { return }
 
     let jsonEncoder = JSONEncoder()
-    let json = try? jsonEncoder.encode(Payload(sources: sources))
-    try? json?.write(to: persistedURL)
+    do {
+      let json = try jsonEncoder.encode(Payload(sources: sources))
+      try json.write(to: persistedURL)
+    } catch {
+      print("Error persisting sources:", error)
+    }
   }
 }

Diff for: LlamaChat/model/sources/SourceNameGenerator.swift

@@ -14,12 +14,15 @@ fileprivate struct Names: Decodable {
 
 class SourceNameGenerator {
   private lazy var names: Names? = {
-    guard
-      let fileURL = Bundle.main.url(forResource: "names", withExtension: "json"),
-      let data = try? Data(contentsOf: fileURL)
-    else { return nil }
+    guard let fileURL = Bundle.main.url(forResource: "names", withExtension: "json") else { return nil }
 
-    return try? JSONDecoder().decode(Names.self, from: data)
+    do {
+      let data = try Data(contentsOf: fileURL)
+      return try JSONDecoder().decode(Names.self, from: data)
+    } catch {
+      print("Error loading source names:", error)
+      return nil
+    }
   }()
 
   var canGenerateNames: Bool {

Diff for: LlamaChat/util/FileUtils.swift

@@ -8,18 +8,18 @@
 import Foundation
 
 func applicationSupportDirectoryURL() -> URL? {
-  guard
-    let bundleIdentifier = Bundle.main.bundleIdentifier,
-    let url = try? FileManager().url(for: .applicationSupportDirectory, in: .userDomainMask, appropriateFor: nil, create: true)
-  else { return nil }
+  guard let bundleIdentifier = Bundle.main.bundleIdentifier else { return nil }
 
-  let appScopedDirectory = url.appendingPathComponent(bundleIdentifier, isDirectory: true)
   do {
+    let url = try FileManager().url(for: .applicationSupportDirectory, in: .userDomainMask, appropriateFor: nil, create: true)
+    let appScopedDirectory = url.appendingPathComponent(bundleIdentifier, isDirectory: true)
+
     if !FileManager.default.fileExists(atPath: appScopedDirectory.path) {
       try FileManager.default.createDirectory(at: appScopedDirectory, withIntermediateDirectories: false)
     }
     return appScopedDirectory
   } catch {
+    print("Error getting application support directory:", error)
     return nil
   }
 }

Diff for: LlamaChat/viewmodel/sources/configure/settings/ConfigureLocalPyTorchModelSettingsViewModel.swift

@@ -145,9 +145,13 @@ class ConfigureLocalPyTorchModelSettingsViewModel: ObservableObject, ConfigureLo
 
     conversionState = .loading
     Task.init {
-      let canConvert = (try? await ModelConverter().canRunConversion()) ?? false
-      await MainActor.run {
-        conversionState = .canConvert(canConvert)
+      do {
+        let canConvert = (try await ModelConverter().canRunConversion())
+        await MainActor.run {
+          conversionState = .canConvert(canConvert)
+        }
+      } catch {
+        print("Error determining model conversion status", error)
       }
     }
   }