Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: webpack factory #130

Merged
merged 2 commits into from
Dec 25, 2018
Merged

feat: webpack factory #130

merged 2 commits into from
Dec 25, 2018

Conversation

njugray
Copy link
Contributor

@njugray njugray commented Dec 21, 2018

  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected plugin(s)

  • webpack

Description of change

support config factory

@codecov-io
Copy link

codecov-io commented Dec 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1524f36). Click here to learn what that means.
The diff coverage is 89.65%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #130   +/-   ##
========================================
  Coverage          ?   91.3%           
========================================
  Files             ?      75           
  Lines             ?    1311           
  Branches          ?       0           
========================================
  Hits              ?    1197           
  Misses            ?     114           
  Partials          ?       0
Impacted Files Coverage Δ
packages/beidou-webpack/lib/factory/plugin.js 100% <100%> (ø)
packages/beidou-webpack/lib/factory/webpack.js 95.2% <88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1524f36...eaf2974. Read the comment docs.

@njugray njugray merged commit 8701f3e into master Dec 25, 2018
@njugray njugray deleted the feat/webpack-factory branch December 25, 2018 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants