Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack error logs missing in building environment #133

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

njugray
Copy link
Contributor

@njugray njugray commented Jan 7, 2019

replace coreLogger with console to avoid logs dismissed under building process.

Checklist

  • npm test passes
  • tests are included
  • commit message follows commit guidelines

Affected plugin(s)

  • beidou-webpack

replace `coreLogger` with `console` to avoid logs dismissed under building process.
@njugray njugray requested a review from justquanyin January 7, 2019 08:49
@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #133 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage    91.3%   91.15%   -0.16%     
==========================================
  Files          75       75              
  Lines        1311     1311              
==========================================
- Hits         1197     1195       -2     
- Misses        114      116       +2
Impacted Files Coverage Δ
packages/beidou-isomorphic/lib/alias.js 80% <0%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edac83f...3a4a1f7. Read the comment docs.

Copy link
Collaborator

@justquanyin justquanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@njugray njugray merged commit feab817 into master Jan 7, 2019
@njugray njugray deleted the fix/webpack-error-log branch January 15, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants