Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: disable exract comments #149

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Fix: disable exract comments #149

merged 1 commit into from
Feb 27, 2019

Conversation

justquanyin
Copy link
Collaborator

@justquanyin justquanyin commented Feb 27, 2019

Checklist

  • [x ] npm test passes
  • [ x] tests are included
  • [ x] documentation is changed or added
  • [ x] commit message follows commit guidelines

Affected plugin(s)

beidou-webpack

Description of change

Disable extract comment by default

#148

@codecov-io
Copy link

codecov-io commented Feb 27, 2019

Codecov Report

Merging #149 into master will increase coverage by 0.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   92.34%   92.86%   +0.51%     
==========================================
  Files          86       86              
  Lines        1542     1542              
==========================================
+ Hits         1424     1432       +8     
+ Misses        118      110       -8
Impacted Files Coverage Δ
...s/beidou-webpack/config/webpack/webpack.browser.js 100% <ø> (ø) ⬆️
packages/beidou-view-rax/lib/rax-view.js 100% <0%> (+23.07%) ⬆️
packages/beidou-view-rax/app/extend/helper.js 100% <0%> (+33.33%) ⬆️
...beidou-view-rax/app/view-middlewares/rax-render.js 100% <0%> (+57.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c1f66...c4a7c94. Read the comment docs.

@njugray njugray merged commit a0b7025 into master Feb 27, 2019
@njugray njugray deleted the bug/extract_license branch March 5, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants