feat: enable contenthash for assets #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 92.89% 93.09% +0.19%
==========================================
Files 86 88 +2
Lines 1563 1593 +30
==========================================
+ Hits 1452 1483 +31
+ Misses 111 110 -1
Continue to review full report at Codecov.
|
|
用来解决webpack打包hash资源命名的问题？ |
justquanyin
reviewed
Apr 1, 2019
| @@ -21,6 +21,7 @@ module.exports = appInfo => ({ | |||
| assetPath: '/build/', | |||
| }, | |||
| view: { | |||
| useHashAsset: false, | |||
There was a problem hiding this comment.
这个配置是在beidou-view的插件下用的，最好放在beidou-view的配置下
| @@ -48,7 +48,7 @@ module.exports = (app, entry, dev) => { | |||
| }); | |||
|
|
|||
| factory | |||
| .definePlugin(ExtractTextPlugin, '[name].css', 'ExtractTextPlugin') | |||
| .definePlugin(ExtractTextPlugin, '[name]_[md5:contenthash:hex:8].css', 'ExtractTextPlugin') | |||
There was a problem hiding this comment.
这里还是不要默认使用hash的方式抽离css文件了
packages/beidou-view/app.js
Outdated
| app.config.view.useHashAsset = false; | ||
| return; | ||
| } | ||
| app.assetManifest = getAssetManifest(app.baseDir); |
| @@ -92,5 +94,17 @@ module.exports = (app, entry, dev) => { | |||
| 'HotModuleReplacementPlugin' | |||
| ); | |||
| } | |||
| if (reservedConfig.assetWithHash && !dev) { | |||
| factory.addPlugin(ManifestPlugin, | |||
| { fileName: path.join(app.baseDir, 'manifest.json') }, | |||
There was a problem hiding this comment.
mapping资源路径最好可配置资源路径。
可参考beidou-isomophic 和 beidou-webpack的共用配置，如不存在这个配置，可使用默认值。
建议是不是也可以看看 assetWithHash也共用一个配置
| @@ -31,6 +31,7 @@ module.exports = (appInfo) => { | |||
| placeHolder: '<!--$render$-->', | |||
| }, | |||
| view: { | |||
| useHashAsset: false, | |||
|
好的 我有空优化下 |
justquanyin
reviewed
Apr 2, 2019
packages/beidou-webpack/README.md
Outdated
| @@ -147,7 +147,7 @@ e.g.： | |||
| { | |||
| webpack: { | |||
| custom: { | |||
| proxy: '/foo*' | |||
| proxy: '/foo*'; | |||
There was a problem hiding this comment.
这是prettier自己加的- -
| @@ -92,5 +93,17 @@ module.exports = (app, entry, dev) => { | |||
| 'HotModuleReplacementPlugin' | |||
| ); | |||
| } | |||
| if (viewConfig.useHashAsset && !dev) { | |||
There was a problem hiding this comment.
判断条件: viewConfig && viewConfig.useHashAsset && !dev
justquanyin
previously approved these changes
Apr 3, 2019
njugray
approved these changes
Apr 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected plugin(s)
beidou-webpack, beidou-view, beidou-view-react, beidou-view-rax
Description of change
#55