Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom config for preset-env #169

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

njugray
Copy link
Contributor

@njugray njugray commented Apr 26, 2019

Solved the warning:

WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.

You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:

  npm install --save core-js@2    npm install --save core-js@3
  yarn add core-js@2              yarn add core-js@3

Checklist

  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected plugin(s)

  • babel-preset-beidou-client

Description of change

for preset-env:

  • set corejs default to 3.0.0
  • support custom config

@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #169 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   92.77%   92.84%   +0.07%     
==========================================
  Files          87       87              
  Lines        1605     1607       +2     
==========================================
+ Hits         1489     1492       +3     
+ Misses        116      115       -1
Impacted Files Coverage Δ
packages/babel-preset-beidou-client/index.js 100% <100%> (ø) ⬆️
packages/beidou-view-rax/lib/rax-view.js 100% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809bdf6...c431ee9. Read the comment docs.

@ahungrynoob
Copy link
Contributor

typo: @babel/reset-react in readme ^ ^

@njugray njugray merged commit ff91b65 into master Apr 26, 2019
@njugray njugray deleted the fix/babel-preset-env-corejs branch April 26, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants