Skip to content

To consider: should Event Topic decoding error if there are too many topics in the iterator? #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
prestwich opened this issue Jun 12, 2023 · 1 comment · Fixed by #863
Open

To consider: should Event Topic decoding error if there are too many topics in the iterator? #107

prestwich opened this issue Jun 12, 2023 · 1 comment · Fixed by #863

Comments

@prestwich
Copy link
Member 

          To consider: should we error if there are too many topics in the iterator?

Originally posted by @prestwich in #83 (comment)
@DaniPopes
Copy link
Member

DaniPopes commented Jun 12, 2023 •
edited
Loading

I think this is fair if we want max correctness maybe with the validate arg.
That should also validate that the first topic is the static hash of the event

@jenpaff jenpaff linked a pull request Mar 4, 2025 that will close this issue
feat(sol-types)!: rm validate: bool #863
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sol-types)!: rm validate: bool alloy-rs/core
2 participants
@prestwich @DaniPopes