Skip to content

[Bug] Signed should have the same APIs as Uint #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DaniPopes opened this issue Nov 23, 2023 · 1 comment
Open

[Bug] Signed should have the same APIs as Uint #431

DaniPopes opened this issue Nov 23, 2023 · 1 comment
Labels
breaking enhancement New feature or request

Comments

@DaniPopes
Copy link
Member

Component

primitives

What version of Alloy are you on?

Latest

Operating System

Linux

Describe the bug

Signed currently has a mix of the ruint::Uint API and the legacy one from Ethers. Most importantly it's missing From<int> / UintTryFrom implementations.
@DaniPopes DaniPopes added the bug Something isn't working label Nov 23, 2023
@prestwich
Copy link
Member

historical reason is that signed has the same interface as ethers, because it was ported from ethers

@jenpaff jenpaff added this to the v1.0 milestone Feb 28, 2025
@jenpaff jenpaff added this to Alloy Feb 28, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Feb 28, 2025
@jenpaff jenpaff removed this from the v1.0 milestone Feb 28, 2025
@jenpaff jenpaff modified the milestone: v1.0 Mar 4, 2025
@jenpaff jenpaff added enhancement New feature or request and removed discuss bug Something isn't working labels Mar 4, 2025
@quentin quentin mentioned this issue Apr 4, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking enhancement New feature or request
Projects
Alloy
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jenpaff @prestwich @DaniPopes