From 285d5fb2da886d823dc9b65faa3524b59f4fd5ed Mon Sep 17 00:00:00 2001 From: Pranjal Aggarwal <54495980+pranjalagg@users.noreply.github.com> Date: Sun, 3 Nov 2024 18:03:42 -0700 Subject: [PATCH 1/7] Add Option to add Resume/CV Link --- _layouts/cv.liquid | 24 +++++++++++++++++------- _pages/cv.md | 2 +- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/_layouts/cv.liquid b/_layouts/cv.liquid index 0ce33a0772db..f7825497af7a 100644 --- a/_layouts/cv.liquid +++ b/_layouts/cv.liquid @@ -53,13 +53,23 @@ layout: default

{{ page.title }} {% if page.cv_pdf %} - + {% if page.cv_pdf contains "http" %} + + + + {% else %} + + + + {% endif %} {% endif %}

{% if page.description %} diff --git a/_pages/cv.md b/_pages/cv.md index ad3e26ddd234..1828d722b087 100644 --- a/_pages/cv.md +++ b/_pages/cv.md @@ -4,7 +4,7 @@ permalink: /cv/ title: cv nav: true nav_order: 5 -cv_pdf: example_pdf.pdf +cv_pdf: http://alberteinstein.eurocv.eu/ description: This is a description of the page. You can modify it in '_pages/cv.md'. You can also change or remove the top pdf download button. toc: sidebar: left From 28439f786a78cdf0750b15adf5e25c3b6133300c Mon Sep 17 00:00:00 2001 From: Pranjal Aggarwal <54495980+pranjalagg@users.noreply.github.com> Date: Sun, 3 Nov 2024 18:04:40 -0700 Subject: [PATCH 2/7] Prettier --- _layouts/cv.liquid | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/_layouts/cv.liquid b/_layouts/cv.liquid index f7825497af7a..320892fe6c55 100644 --- a/_layouts/cv.liquid +++ b/_layouts/cv.liquid @@ -53,12 +53,13 @@ layout: default

{{ page.title }} {% if page.cv_pdf %} - {% if page.cv_pdf contains "http" %} + {% if page.cv_pdf contains 'http' %} + class="float-right" + > {% else %} @@ -66,7 +67,8 @@ layout: default href="{{ page.cv_pdf | prepend: 'assets/pdf/' | relative_url}}" target="_blank" rel="noopener noreferrer" - class="float-right"> + class="float-right" + > {% endif %} From 57719e2e391fa45031bc1ed7db0be3b56577067a Mon Sep 17 00:00:00 2001 From: Pranjal Aggarwal <54495980+pranjalagg@users.noreply.github.com> Date: Thu, 28 Nov 2024 13:20:22 -0700 Subject: [PATCH 3/7] Implimented Suggestions --- _layouts/cv.liquid | 27 ++++++++++----------------- _pages/cv.md | 2 +- 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/_layouts/cv.liquid b/_layouts/cv.liquid index 320892fe6c55..f882b401eca5 100644 --- a/_layouts/cv.liquid +++ b/_layouts/cv.liquid @@ -53,25 +53,18 @@ layout: default

{{ page.title }} {% if page.cv_pdf %} - {% if page.cv_pdf contains 'http' %} - - - - {% else %} - - - - {% endif %} + {% endif %} + target="_blank" + rel="noopener noreferrer" + class="float-right" + > + + {% endif %}

{% if page.description %} diff --git a/_pages/cv.md b/_pages/cv.md index 1828d722b087..ad3e26ddd234 100644 --- a/_pages/cv.md +++ b/_pages/cv.md @@ -4,7 +4,7 @@ permalink: /cv/ title: cv nav: true nav_order: 5 -cv_pdf: http://alberteinstein.eurocv.eu/ +cv_pdf: example_pdf.pdf description: This is a description of the page. You can modify it in '_pages/cv.md'. You can also change or remove the top pdf download button. toc: sidebar: left From b33a50e571f1b078d08cbc150ce87c3da140bb97 Mon Sep 17 00:00:00 2001 From: Pranjal Aggarwal <54495980+pranjalagg@users.noreply.github.com> Date: Fri, 29 Nov 2024 08:11:56 -0700 Subject: [PATCH 4/7] Replace http check with :// in cv.liquid --- _layouts/cv.liquid | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_layouts/cv.liquid b/_layouts/cv.liquid index f882b401eca5..024ce25bc70c 100644 --- a/_layouts/cv.liquid +++ b/_layouts/cv.liquid @@ -54,7 +54,7 @@ layout: default {{ page.title }} {% if page.cv_pdf %} Date: Sat, 30 Nov 2024 00:01:00 -0700 Subject: [PATCH 5/7] Space after relative_url --- _layouts/cv.liquid | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_layouts/cv.liquid b/_layouts/cv.liquid index 024ce25bc70c..88dac2a18b1b 100644 --- a/_layouts/cv.liquid +++ b/_layouts/cv.liquid @@ -57,7 +57,7 @@ layout: default {% if page.cv_pdf contains '://' %} href="{{ page.cv_pdf }}" {% else %} - href="{{ page.cv_pdf | prepend: 'assets/pdf/' | relative_url}}" + href="{{ page.cv_pdf | prepend: 'assets/pdf/' | relative_url }}" {% endif %} target="_blank" rel="noopener noreferrer" From e7bc8905ddd8232f1bac42bc5f66e8016ca8fec4 Mon Sep 17 00:00:00 2001 From: Pranjal Aggarwal <54495980+pranjalagg@users.noreply.github.com> Date: Mon, 2 Dec 2024 15:47:08 -0700 Subject: [PATCH 6/7] Add comment to indicate ability to include resume links --- _pages/cv.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_pages/cv.md b/_pages/cv.md index ad3e26ddd234..d79c154bcef6 100644 --- a/_pages/cv.md +++ b/_pages/cv.md @@ -4,7 +4,7 @@ permalink: /cv/ title: cv nav: true nav_order: 5 -cv_pdf: example_pdf.pdf +cv_pdf: example_pdf.pdf # you can replace it with a link to your resume as well description: This is a description of the page. You can modify it in '_pages/cv.md'. You can also change or remove the top pdf download button. toc: sidebar: left From 28a57a7a11463f2fa2ec2ea3d816706f96f796a0 Mon Sep 17 00:00:00 2001 From: Pranjal Aggarwal <54495980+pranjalagg@users.noreply.github.com> Date: Mon, 2 Dec 2024 20:04:33 -0700 Subject: [PATCH 7/7] Comment Update --- _pages/cv.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_pages/cv.md b/_pages/cv.md index d79c154bcef6..f13f402d8ecd 100644 --- a/_pages/cv.md +++ b/_pages/cv.md @@ -4,7 +4,7 @@ permalink: /cv/ title: cv nav: true nav_order: 5 -cv_pdf: example_pdf.pdf # you can replace it with a link to your resume as well +cv_pdf: example_pdf.pdf # you can also use external links here description: This is a description of the page. You can modify it in '_pages/cv.md'. You can also change or remove the top pdf download button. toc: sidebar: left